-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Projects Page Header to match the new Figma design #2355
Comments
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. You are receiving this comment because your last comment was before Monday, February 7, 2022 at 11:17 PM PST. |
I'll be removing myself from the issue for the time being. Here is the code I worked on and it works for desktop and mobile on the new Figma design for the product page header. If someone wants to cut and paste this code in correct files and work on fixing details (like tablet view), this is a good starting point for working on this issue as most of the layout is already done...make sure to match it up with existing site to see which changes were made. pages/projects-page.html
_sass/elements/_containers.scss
|
Availability: 4hrs |
Hi @neevliberman, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
Availabilty: 1 hr |
I'm a bit confused, wasn't #3087 merged? Didn't that code make all the changes requested here? Maybe there's an update to the design here that I'm not catching, but it seems like the code that Jaretzbalba wrote made all the changes necessary. If somebody can help me understand that'd be great! |
@neevliberman Apologies for the confusion, I am unassigning you because this issue has been already completed but remained open. @Jaretzbalba made all the necessary changes with PR has been approved and merged to PS: we don't have GHA that runs, and closes issues automatically once the PR merges except the I am closing this issue now as completed. |
Overview
We need to update the HTML content and CSS styling so that we match the Updated Figma Design for the Projects Page Header
Before Changes
Current - Projects Page Header - Desktop
Current - Projects Page Header - Desktop
Current - Projects Page Header - Mobile
Current - Projects Page Header - Mobile
After Changes
Figma - Projects Page Header - Desktop (match this)
Figma - Projects Page Header - Desktop (match this)
Figma - Projects Page Header - Mobile (match this)
Figma - Projects Page Header - Mobile (match this)
Action Items
Resources/Instructions
Updated Figma Design - Projects Page Header
#1051 (Design issue for reference)
website/pages/projects-page.html
Lines 1 to 24 in 8503893
website/_sass/elements/_containers.scss
Lines 83 to 104 in a159ab4
The text was updated successfully, but these errors were encountered: