-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the new design for the top navigation bar #2455
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@answebdev Do you need help with your blocker? |
@JessicaLucindaCheng Yes, I think I do. Basically, I have the navbar redesign finished and working according to the Figma designs (see below). But what I'm stuck on is getting the dropdown items into separate The anchor tags also need to be sorted out. I was planning on writing a comment when I finished about creating an issue to deal with the anchor tags, as discussed in a previous meeting with Bonnie, but since I'm stuck on this, I haven't gotten to that yet. Right now, this is where I'm stuck on, and this is what the navbar looks like when putting the navbar items and their dropdowns in separate |
Hi @danajeon, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
i. Availability: Mon-Fri 4-7PM EST |
I'll be busy for the remainder of this week and next week and won't be able to finish this issue by 5/3 EOD, I've unassigned myself from this issue. |
Hi @ramitaarora, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
i. Availability: Weekdays 9am-12pm |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the You are receiving this comment because your last comment was before Tuesday, May 7, 2024 at 12:06 AM PST. |
I am blocked: I have an issue where the toolkit anchor tags are not working, but it seems the "/toolkit/" link itself is not working. When I navigate to "/toolkit/" or "/toolkit", it redirects to "/toolkit/?". I have tried changing the slashes but it has not seemed to work yet. |
@ramitaarora This behavior is probably happening because of the event handlers in |
@ramitaarora I moved this issue back to the in progress column since it seems like you got your answer. If you need more support, please move this issue back to the questions column and add the |
PR #6854 fixes this issue, closing as completed |
Dependency
Overview
We need to implement the new figma design for our main navigation bar so it's more user friendly.
Click here to see current HfLA navigation bar
Click here to see the proposed navigation bar (Figma design)
Note: Feature Branch
The pull request created from this issue should be pushed into a feature branch called "feature-homepage-launch." Please note this wiki article on how to work off of a feature branch.
Action Items
_data/navigation
New hover-over menu items
Remove red hover-over text for top level menu items
Dropdown has 93% opacity
Resources/Instructions
Feature branch wiki article
Figma - New navigation bar design
Navigation data directory
Click below to see main nav bar
website/_includes/main-nav.html
Lines 1 to 14 in 66f8931
Related issues:
The text was updated successfully, but these errors were encountered: