Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug on code of conduct #2632

Closed
1 of 3 tasks
Aveline-art opened this issue Dec 27, 2021 · 9 comments · Fixed by #3656
Closed
1 of 3 tasks

Bug on code of conduct #2632

Aveline-art opened this issue Dec 27, 2021 · 9 comments · Fixed by #3656
Assignees
Labels
Bug Something isn't working Complexity: Medium Feature: Administrative Administrative chores etc. role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Comments

@Aveline-art
Copy link
Member

Aveline-art commented Dec 27, 2021

Overview

This is a bug that I have found.

When I was searching through Google for our code of conduct, it gave me a link to an incomplete page. Please look at the resources for more information.

Note: Might overlap with #110. I'm not sure 😔

Action Items

  • Explore ways to keep Broken code of conduct page from displaying when the site is googled.
    • Try the following possible approach: Jekyll's configuration accepts file exclusions, which prevents the file from being considered when site is built.
  • Make sure the fix/changes do not affect other parts of the website.

Resources/Instructions

Google search

Broken code of conduct page

  • Please read through the commens for additional information and links
@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Dec 27, 2021
@github-actions
Copy link

Hi @Aveline-art.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
Size, Role, Feature

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Jan 5, 2022

I realized why this page is in our main dir: https://github.com/hackforla/website/blob/gh-pages/CODEOFCONDUCT.md Its part of GitHub's health files https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/creating-a-default-community-health-file

So the question is how do we keep it from displaying when the site is googled.

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers role missing and removed role missing role: front end Tasks for front end developers labels Jan 9, 2022
@Aveline-art
Copy link
Member Author

@ExperimentsInHonesty Jekyll's configuration accepts file exclusions, which prevents the file from being considered when site is built. Not sure if this works, but worth a shot?

@SAUMILDHANKAR SAUMILDHANKAR added Bug Something isn't working Feature: Administrative Administrative chores etc. role: back end/devOps Tasks for back-end developers Complexity: Medium Ready for Prioritization size: 1pt Can be done in 4-6 hours and removed role missing size: missing Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Jan 29, 2022
@Providence-o Providence-o added this to the z. Excellent level milestone Jan 29, 2022
@michaelmagen michaelmagen self-assigned this Oct 13, 2022
@github-actions
Copy link

Hi @michaelmagen, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@michaelmagen
Copy link
Member

Availability: 4 hours
ETA: 10/16/22

@github-actions github-actions bot added Status: Updated No blockers and update is ready for review 2 weeks inactive An issue that has not been updated by an assignee for two weeks and removed Status: Updated No blockers and update is ready for review labels Oct 14, 2022
@github-actions
Copy link

@michaelmagen

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, October 18, 2022 at 12:33 AM PST.

@blulady
Copy link
Member

blulady commented Oct 21, 2022

Hi @michaelmagen,
So we went ahead last night and made the edit you suggested.
Unfortunately now google search links directly to the CODEOFCONDUCT.md instead of the html.
We're going to role it back but @jdingeman recommended looking at
https://github.com/jbranchaud/til/blob/master/html/prevent-search-engines-from-indexing-a-page.md

@michaelmagen
Copy link
Member

Progress: Need to check with others about testing of new approach
Blockers: Initial approach did not work, attempting new approach to solve problem
Availability: 4 hours
ETA: 10/25/22

@michaelmagen michaelmagen added Status: Updated No blockers and update is ready for review and removed Status: Updated No blockers and update is ready for review labels Oct 24, 2022
@blulady
Copy link
Member

blulady commented Oct 25, 2022

Progress: Need to check with others about testing of new approach Blockers: Initial approach did not work, attempting new approach to solve problem Availability: 4 hours ETA: 10/25/22

Thanks for updating. I'll remove the two-weeks inactive label but feel free to do it yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Complexity: Medium Feature: Administrative Administrative chores etc. role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging a pull request may close this issue.

7 participants