Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design a fix the dropdown menu design for projects page #3277

Closed
6 tasks done
sijiapitts opened this issue Jun 21, 2022 · 29 comments
Closed
6 tasks done

Design a fix the dropdown menu design for projects page #3277

sijiapitts opened this issue Jun 21, 2022 · 29 comments
Assignees
Labels
Complexity: Missing P-Feature: Projects page https://www.hackforla.org/projects/ role: design size: 5pt Can be done in 19-30 hours

Comments

@sijiapitts
Copy link
Member

sijiapitts commented Jun 21, 2022

Overview

During a site audit on Figma design file and on the website, we noticed that the drop-down menu design is not consistent. Each page has its own font size, margin, padding, etc.

We decided that the first step is to fix the dropdown menu on the toolkit page. Afterwards, we will move on to the projects page and wins page.

Update

The toolkit page met a blocker, so the team decided to finish the project page first

Action Items

  • Fix the inconsistency of padding
  • Fix the inconsistency of font sizes
  • Determine the layout
  • Determine design details of the dropdown
  • Implement the new design
  • Review with design lead

Resources/Instructions

Design Systems
Figma workfile
Final design

@sijiapitts sijiapitts added Status: Urgent Needs to be worked on immediately Dependency An issue is blocking the completion or starting of another issue size: 0.5pt Can be done in 3 hours or less labels Jun 21, 2022
@sijiapitts sijiapitts self-assigned this Jun 21, 2022
@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing labels Jun 21, 2022
@github-actions

This comment was marked as outdated.

@phuonguvan phuonguvan added P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: design Ready for Prioritization and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing labels Jun 30, 2022
@phuonguvan

This comment was marked as outdated.

@sijiapitts
Copy link
Member Author

@phuonguvan I have included the Figma link to the descriptions.

I will still be working on fixing the dropdown menu. But because we may add more toolkit categories in the future, we will need to change the web menu design to dropdown menus as well (like the project page and wins page). When working on this issue, I will use the project page as a reference.

@sijiapitts
Copy link
Member Author

Blocker: Do we need a multi select dropdown (dropdown with check box) for the toolkit page?

Because the nature of the toolkit page, I think users rarely will need to select multiple categories at the same time. In this case, a single select dropdown may be more intuitive and easier to use.

@sijiapitts
Copy link
Member Author

  1. Progress: Clarified the design direction for toolkit filters during the meeting on 7/10. We are trying to make the toolkit page filter work the same way as the landing page. Will create multiple filters(practice area, tools, and status) and checkboxs inside of dropdown (so people can select multiple items).
  2. Blockers: No blockers
  3. Availability: 5 hours
  4. ETA: by the next meeting on 7/13

@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added this to the 05. Know HFLA milestone Sep 1, 2022
@ExperimentsInHonesty ExperimentsInHonesty removed the Dependency An issue is blocking the completion or starting of another issue label Sep 1, 2022
@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Sep 2, 2022
@github-actions

This comment was marked as outdated.

@7kram

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added 2 weeks inactive An issue that has not been updated by an assignee for two weeks and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks Ready for Prioritization labels Sep 8, 2022
@github-actions

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty removed the time sensitive Needs to be worked on by a particular timeframe label Oct 24, 2022
@blulady

This comment was marked as outdated.

@blulady

This comment was marked as outdated.

@blulady blulady added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Oct 26, 2022
@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Ready for Prioritization labels Nov 6, 2022
@blulady

This comment was marked as outdated.

@blulady blulady added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Nov 13, 2022
@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Nov 14, 2022

@blulady I think we can make an issue for dev to build this function and while they are building it, take into account accessibility of navigating the filters with keyboard. See these Resources come from this comment from Z on another issue

Resources

Dependency

once you make the issue stick it in the icebox with the following

### Dependency 
- #3256 

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Ready for Prioritization labels Nov 20, 2022
@blulady
Copy link
Member

blulady commented Nov 24, 2022

See the previous comment from Sijia.

Additional Note for Dev Lead Writing This Issue: This is a new visual version of how the filters will appear. When refactoring it, the goal is to make it a component that can be re-used on multiple pages with different filters specified

Drafting up this issue, saw that issue #3626 is also ready for dev lead per the comment quoated above do we want to make this issue a dependency for #3626?

@blulady blulady added ready for product Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Nov 24, 2022
@blulady
Copy link
Member

blulady commented Nov 25, 2022

So I went to make the new issue and went ahead and looked at issue

@blulady
Copy link
Member

blulady commented Nov 25, 2022

@blulady I think we can make an issue for dev to build this function and while they are building it, take into account accessibility of navigating the filters with keyboard. See these Resources come from this comment from Z on another issue

Resources

* [Keyboard Accessible - sufficient techniques](https://www.w3.org/WAI/WCAG21/quickref/?showtechniques=211#principle2)

* [Using CSS when component receives focus](https://www.w3.org/WAI/WCAG21/Techniques/css/C15.html) - [Focus visible](https://www.w3.org/WAI/WCAG21/Understanding/focus-visible)

* [Navigable Guideline 2.4](https://www.w3.org/WAI/standards-guidelines/wcag/new-in-22/)

* [Focus Not Obscured](https://www.w3.org/WAI/standards-guidelines/wcag/new-in-22/#2412-focus-not-obscured-minimum-aa)

* [Draft - Understanding Focus Not Obscured](https://www.w3.org/WAI/WCAG22/Understanding/focus-not-obscured-minimum)

Dependency

once you make the issue stick it in the icebox with the following

### Dependency 
- #3256 

So I went to make the new issue and went ahead and looked at issue

@ExperimentsInHonesty
Copy link
Member

@ExperimentsInHonesty ExperimentsInHonesty changed the title Fix the dropdown menu design for projects page Design a fix the dropdown menu design for projects page Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Missing P-Feature: Projects page https://www.hackforla.org/projects/ role: design size: 5pt Can be done in 19-30 hours
Projects
Development

No branches or pull requests

5 participants