Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Google Apps Script to validate URLs and report failures in GitHub review issue #4405

Closed
2 of 7 tasks
roslynwythe opened this issue Apr 4, 2023 · 3 comments
Closed
2 of 7 tasks
Assignees
Labels
Complexity: Large Dependency An issue is blocking the completion or starting of another issue Draft Issue is still in the process of being created P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers size: missing
Milestone

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Apr 4, 2023

Dependency

Overview

URL validation in the wins Google form is inadequate, so in the Google Apps Script behind the wins-form (response) Sheet, we will test URLs for valid format. If a URL is found to be invalid, a message will be displayed within the GItHub review issue, and the URL will not be included in the _wins-data.json feed.

Action Items

Setup

  • Obtain access to the wins form, the wins-form (response) Sheet, the Secret files and the Wins Admin Guide. Make a copy of the wins form, wins-form (response) Sheet, and Secret files, placing the copies on your local Google Drive. All subsequent modifications should be made on your local Google Drive copies.
  • Read the Wins Admin Guide to understand the flow of data between the wins form, the wins-form (response) Sheet, the GitHub review issue and the wins data feed.
  • read the wiki "Hfla Google Apps Script Development/Review Process" and follow instructions to setup your local environment. Follow instructions for connecting your wins-form with the wins-form (response) Sheet, and configuring triggers in the wins-form (response) Sheet.

Code Changes

  • In Code.gs behind gh-requests, modify the function createIssue() so that it accepts a string input parameter message that will be displayed in the body of the new GitHub review issue.
  • In Code.gs behind wins-form (response) Sheet, prior to invoking ghrequests.createIssue(), test the GitHub and LinkedIn URLs for valid format. If the test fails, generate a descriptive message and supply the message as an input parameter to ghrequests.createIssue().

Resources/Instructions

@roslynwythe roslynwythe added role: back end/devOps Tasks for back-end developers Complexity: Large P-Feature: Wins Page https://www.hackforla.org/wins/ labels Apr 4, 2023
@roslynwythe roslynwythe self-assigned this Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Hi @roslynwythe, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@ExperimentsInHonesty
Copy link
Member

@roslynwythe Friendly reminder to add a size label to this issue

@roslynwythe roslynwythe added the Draft Issue is still in the process of being created label Jun 5, 2023
@roslynwythe
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Dependency An issue is blocking the completion or starting of another issue Draft Issue is still in the process of being created P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers size: missing
Projects
Development

No branches or pull requests

3 participants