Update PR template with instructions regarding spell check messages

[roslynwythe]

Dependencies

• Add Code Spell Checker VS Code extension installation instructions #4101
• add instructions for workstation spell checking using npm package #5652
• Epic: Create issues to add false positives to cspell.json #5312
• Epic: Create issues to add ignorePaths to cSpell configuration file #5450
• Epic: Create template, spreadsheet and list of issues for spellcheck audit #5248
• New wiki page "How to manage spell check warnings" ??
• Epic: Create template, spreadsheet and list of issues for spellcheck audit #5248
• Create issue template "Resolve Spell Check warning" #6446

Overview

We need to direct developers how to manage spell check messages on changed files locally, and also those that may appear in Pull Request checks. Developers will be instructed to correct spelling errors where appropriate, modifying cspell.json as appropriate to suppress false positives, and to note changes in a new section of the PR template "What changes did you make in response to code linter recommendations?"

Action Items

• Open the file .github/pull_request_template.md in your IDE
• Following the section "Why did you make the changes (we will use this info to test)?" add this section:

Note to developers:
- [ ] If spell check warnings ("unknown word") are displayed either locally (in VS Code Spell Check Extension) or in GitHub PR checks, follow instructions in "How to manage spell check warnings"
- [ ] Alternatively, create a new issue based on the template "Resolve Spell Check warning"
- [ ] If any file changes are made in response to linter warnings, document those in the pull request, in the section "What changes did you make?

Resources/Instructions

(#4786 (comment))

[ExperimentsInHonesty]

at the 2024-03-04 dev/pm meeting we reviewed this issue and it seems like we need to figure out how this affects new developers on the project.

[roslynwythe]

@ExperimentsInHonesty we decided that the initial PR instructions were too complex for junior developers. I edited the action items so that developers have a wiki page "How to manage spell check warnings" to refer to for instructions, and they also can create an issue with a new template "Resolve Spell Check Warning".