Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run VSCode Spell Checker on _includes/about-page/about-card-sustainability.html #5527

Closed
8 of 9 tasks
Tracked by #5248
roslynwythe opened this issue Sep 15, 2023 · 7 comments
Closed
8 of 9 tasks
Tracked by #5248
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Sep 15, 2023

Overview

We need to audit HfLA codebase files for spelling errors using the VSCode Code Spell Checker extension in order to ensure site quality. Results will be categorized as misspellings, false positives in the HfLA spelling audit spreadsheet1 and will be resolved in later issues.

Action Items

  • You must use VS Code as your local text editor and install the Code Spell Checker VS Code extension2
  • Do not change any configuration settings or make any spell corrections
  • Open the file '_includes/about-page/about-card-sustainability.html' and note any Code Spell Checker errors
  • Locate the file in column A ("File") of the "Page Audit" sheet. In the column labelled "Result Summary", select the appropriate option: No errors or At least one error.
  • If at least one error was reported, copy/paste each cSpell message into a separate row in the Results sheet
  • In each new row, select the appropriate value: misspelling or false positive from the "Result type" column. A false positive is a term that is not a misspelling, but it is not recognized by the spell checker because it is a technical term, abbreviation, acronym, URL or proper noun (name of a person, place or organization).
  • Move this issue to the Questions/In Review column and apply the label 'ready for dev lead`

Merge Team

Resources/Instructions

Footnotes

  1. HfLA spelling audit spreadsheet - Results

  2. The recommended installation method is to install Code Spell Checker directly from the VS Code text editor, and those instructions can be found here. The extension can also be installed via the VS Code Marketplace website here.

@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 15, 2023
@github-actions
Copy link

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

@roslynwythe roslynwythe changed the title _includes/about-page/about-card-sustainability.html Run VSCode Spell Checker on _includes/about-page/about-card-sustainability.html Sep 15, 2023
@roslynwythe roslynwythe added Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 15, 2023
@roslynwythe roslynwythe added this to the x. Technical debt milestone Sep 15, 2023
@locb65 locb65 self-assigned this Sep 15, 2023
@github-actions
Copy link

Hi @locb65, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@locb65
Copy link
Member

locb65 commented Sep 15, 2023

Availability: Everyday after 6pm EST.
ETA: 1-2 hours after starting. Planning to start and finish 9/16/2023

@locb65
Copy link
Member

locb65 commented Sep 20, 2023

@roslynwythe
Hi Roslyn. I have a question.

Locate the file in column A ("File") of the "Page Audit" sheet. In the column labelled "Result Summary", select the appropriate option: No errors or At least one error.

Where exactly is the file above?

I have been looking for it for quite some time. Any direction helps. Thank You!

@locb65 locb65 added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Sep 29, 2023
@LRenDO
Copy link
Member

LRenDO commented Oct 4, 2023

Hi @locb65! Great job with this issue! It looks like there were false positive errors on this page on my end too! You did a great job adding them to the sheet correctly. You also did a great job with moving the issue to the right column and adding the correct label.

Strangely, "Collabathon" didn't show up as an error on my end which theoretically it should have. Let's go ahead and leave it on there in case it's something with my version, but I do have a request for it.

  • On the Results sheet of the spreadsheet in the Result type column, please change the type to False Positive because it is the correct word we want to use on the site (it's the name of an event, I believe).

Once it's completed, you can ping me here in a comment to let me know and add the ready for dev lead tag back to the issue. Thanks for working on this issue!

@LRenDO LRenDO removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 4, 2023
@locb65
Copy link
Member

locb65 commented Oct 4, 2023

Hi @LRenDO. The have implemented the changes to the spreadsheet that you asked for. I assumed that Collabathon could be an event name as it does sound like one, but I was not too sure. I am placing the ready for dev lead tag back on.

@locb65 locb65 added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 4, 2023
@LRenDO
Copy link
Member

LRenDO commented Oct 4, 2023

Hi @locb65! Looks great! Thanks for making the update!

@LRenDO LRenDO closed this as completed Oct 4, 2023
@ExperimentsInHonesty ExperimentsInHonesty added feature: spelling and removed Feature: Administrative Administrative chores etc. labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

No branches or pull requests

4 participants