Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: Issue with Public Facing Slack Channel Links for Non members #6129

Open
2 of 5 tasks
djbradleyii opened this issue Jan 17, 2024 · 10 comments
Open
2 of 5 tasks

ER: Issue with Public Facing Slack Channel Links for Non members #6129

djbradleyii opened this issue Jan 17, 2024 · 10 comments
Assignees
Labels
Complexity: Large Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ER Emergent Request Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: Getting Started https://www.hackforla.org/getting-started P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Help Wanted Internal assistance is required to make progress

Comments

@djbradleyii
Copy link
Member

djbradleyii commented Jan 17, 2024

Emergent Requirement - Problem

Prospective members might have been attempting to join slack channels via public facing links. Since they aren't members they are unable to join.

Issue you discovered this emergent requirement in

Date discovered

1/17/24

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@bonniewolfe @djbradleyii @nelsonuprety1

What happens if this is not addressed

Prospective members might attempt to join these slack channels, but will be unable to due to the fact that they are not members resulting in a poor user experience. This might deter potential members from reaching out or associating with HackforLA.

Resources

Screen Shot of Community of Practice Slack link

Screenshot 2023-11-29 at 18 12 39

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

Make an issue to determine the technical feasibility of the below
if the issue is feasible, do we have to make unique pages, or can we do it dynamically. If we can do it dynamically, then go ahead and execute. If we need separate pages, write-up how it would work and make a template for making each page, then get sign-off by dev lead and product.

Using an Iframe, and deliver a page that says

The link below goes to a Slack channel inside Hack for LA's Slack Workspace

If you are a member of our community already, selecting the link below will take to the channel. 

If you are not yet a member of our community, please see our [Getting Started](https://www.hackforla.org/getting-started) page to join.

and then has a unique link for the team's slack link they just clicked on

[INSERT TEAM SLACK LINK NAME or CoP NAME THAT WILL LINK TO TEAM/CoP SLACK LINK THAT YOU JUST CAME FROM]

Add this resource to the issue and whatever resources from above that are applicable.

Resources

@djbradleyii djbradleyii added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: 0.25pt Can be done in 0.5 to 1.5 hours role missing Complexity: Missing labels Jan 17, 2024

This comment was marked as outdated.

@djbradleyii djbradleyii changed the title ER: [replace with info ] ER: Issue with Public Facing Slack Channel Links for Non members Jan 17, 2024
@ExperimentsInHonesty ExperimentsInHonesty added Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Getting Started https://www.hackforla.org/getting-started P-Feature: Projects page https://www.hackforla.org/projects/ role: design lead Issue Making: Level 2 Make issue(s) from an ER or Epic and removed Complexity: Missing Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing labels Jan 17, 2024
@ExperimentsInHonesty ExperimentsInHonesty added the ER Emergent Request label Jan 18, 2024
@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty moved this to ERs and epics that are ready to be turned into issues in P: HfLA Website: Project Board Jun 23, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this from ERs and epics that are ready to be turned into issues to In progress (actively working) in P: HfLA Website: Project Board Nov 27, 2024
@HackforLABot
Copy link
Contributor

Hi @siyunfeng, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@ExperimentsInHonesty
Copy link
Member

Once this issue is made - assign it to Siyun.

@siyunfeng
Copy link
Member

Availability: 6-9 PM Weekdays (EDT)
ETA: 12/4/2024 Wednesday

@siyunfeng
Copy link
Member

siyunfeng commented Dec 5, 2024

@ExperimentsInHonesty , the src attribute in the iframe should be either a URL or an HTML file. I considered using an HTML file because we are not adding an existing website above the slack channel button. However, all the HTML files have a default setting with the same layout as the other pages like the below example:

Screenshot of iframe Example

Screenshot of iframe Example

The page won't fit in the iframe because it will heritage all the layouts and elements as a default page.
Should we use a <p> element instead of an iframe for the notification above both the Join Slack Channel and View GitHub buttons?

Screenshot of p tage Example

Screenshot of p tag example

@siyunfeng siyunfeng added the Status: Help Wanted Internal assistance is required to make progress label Dec 5, 2024
@siyunfeng
Copy link
Member

Provide Update

  1. Progress: I haven't created the issue because using iframe in the instruction won't provide the user experience we want to improve
  2. Blockers: using iframe will show too much extra content that we don't need for this issue
  3. Availability: 6-9 PM Weekdays (EDT)
  4. ETA: 12/20/2024 Friday

@siyunfeng siyunfeng moved this from In progress (actively working) to Questions / In Review in P: HfLA Website: Project Board Jan 14, 2025
@siyunfeng
Copy link
Member

Provide Update

  1. Progress: I haven't created the issue because using iframe in the instruction won't provide the user experience we want to improve
  2. Blockers: I need help with clarifying the correct approach to this ER
  3. Availability: 6-9 PM Weekdays (EDT)
  4. ETA: 1/19/2024 Sunday (once I clarify the correct process to solve this ER)

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Jan 28, 2025

@siyunfeng I reviewed your screen mockups. I guess the notes in the ER are not clear enough about the proposed solution. We are not suggesting that the iframe is in the community of practice page, but rather clicking on the slack link takes you to a page, that has the paragraph at the top, and the slack results in the bottom portion. That way it would work no matter what page the slack link is on.

If you have additional questions, please make sure to add the ready for product label to your issue once you have put it in the questions column.

@ExperimentsInHonesty ExperimentsInHonesty moved this from Questions / In Review to In progress (actively working) in P: HfLA Website: Project Board Jan 28, 2025
@siyunfeng
Copy link
Member

@siyunfeng I reviewed your screen mockups. I guess the notes in the ER are not clear enough about the proposed solution. We are not suggesting that the iframe is in the community of practice page, but rather clicking on the slack link takes you to a page, that has the paragraph at the top, and the slack results in the bottom portion. That way it would work no matter what page the slack link is on.

If you have additional questions, please make sure to add the ready for product label to your issue once you have put it in the questions column.

@ExperimentsInHonesty , thanks for clarifying. FYI I'll be on vacation for the next 3 weeks and I'll continue working on this ER when I'm back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ER Emergent Request Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: Getting Started https://www.hackforla.org/getting-started P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Help Wanted Internal assistance is required to make progress
Projects
Status: In progress (actively working)
Development

No branches or pull requests

4 participants