Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Team Meeting data on the Events page to show meeting frequency #6920

Closed
4 tasks done
Thinking-Panda opened this issue May 31, 2024 · 18 comments · Fixed by #7043, #7086 or #7088
Closed
4 tasks done

Update Team Meeting data on the Events page to show meeting frequency #6920

Thinking-Panda opened this issue May 31, 2024 · 18 comments · Fixed by #7043, #7086 or #7088
Assignees
Labels
Complexity: Medium P-Feature: Events https://www.hackforla.org/events/ P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Project Meetings https://www.hackforla.org/project-meetings role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@Thinking-Panda
Copy link
Member

Thinking-Panda commented May 31, 2024

Overview

Currently the Online Project Team Meeting section of Events page has Day, Start Time, End Time, Name of Project, and Name of Meeting. As some of the meetings do not happen weekly (like Onboarding), we need to mark those meetings and add a message to visit project page for more information.

Action Items

  • Analyze and understand the data in _data/external/vrms_data.json
  • Update Team Meeting data on the Events page to add asterisk to the end of "Name of Meeting" if it's not weekly.
  • Add the following text to the end of the "Online Project Team Meetings" section.
    *This meeting is not weekly, check project link for more details.
    
  • Using Docker, check the changes on your local machine

Resources/Instructions

@Thinking-Panda Thinking-Panda added role: front end Tasks for front end developers Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Events https://www.hackforla.org/events/ Ready for Prioritization P-Feature: Project Meetings https://www.hackforla.org/project-meetings size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 31, 2024
@colin-macrae colin-macrae self-assigned this Jun 3, 2024

This comment was marked as outdated.

@colin-macrae

This comment was marked as outdated.

@Thinking-Panda

This comment was marked as outdated.

@colin-macrae
Copy link
Member

Hi @Thinking-Panda - What's the best way for me to find out the frequency of meetings (in order to find out which ones are not weekly). I didn't see anything about frequency in the json data nor on the meeting pages. Many thanks, Colin

@Thinking-Panda
Copy link
Member Author

@colin-macrae The meeting frequency is mentioned under "description" in the JSON file.

@colin-macrae
Copy link
Member

Hi @Thinking-Panda , thank you! Many of those "description" properties have no values, and many don't mention anything about frequency. So, here is what I'll do, and please do let me know if I should do differently:

  • For all empty values for "description", I will do nothing
  • For all which do not explicitly say meetings are not weekly, I will do nothing
  • For all which explicitly say meetings are not weekly, I will make the requested changes (asterisk etc..)

Does that sound right? Thanks again, Colin

@Thinking-Panda
Copy link
Member Author

Hi @colin-macrae , that's right. The key "description" has a value only when the meeting is not weekly.

@colin-macrae
Copy link
Member

Hi @Thinking-Panda - Okay, and just to be extra sure, the event in the pic below is not weekly since the description key has a value (even though there is no mention of frequency). I'll make the prescribed changes to all which are like this one, and no changes to those with no values. Pls kindly confirm. Many thanks!

image

@Thinking-Panda
Copy link
Member Author

@colin-macrae the "description" in line 210 is not the description of the event. It is the description of the project. Scroll a little further to see the event description with no value. Hope this helps.

@colin-macrae
Copy link
Member

@Thinking-Panda , got it! So many descriptions for each object 🤣. I see that now, and thanks for your patience. ETA is before Thursday (will update above). Thanks again!

@colin-macrae colin-macrae removed their assignment Jun 14, 2024
@colin-macrae
Copy link
Member

Unfortunately I had to unassign myself from this issue for a couple of reasons.

First, I have not used the technologies required to complete the issue and either A) the instructions were a bit vague or B) my inexperience with the site, this file system, and this frontend tech represented a blocker. I tried to get help through dev office hours on Thursday but there was no one there while I waited, from 7-7:10pm. Aside from that I'm traveling out of the country in a couple days and I wouldn't be able to revisit it after today, probably for a few weeks.

I'll look for another issue to pick up, explore moving to a React project, and review some PRs. Many thanks.

@colin-macrae
Copy link
Member

colin-macrae commented Jun 14, 2024

@Thinking-Panda , if you want to add these to the issue action items, it could prevent a lot of double work. I've compiled the the list of teams whose meetings are not weekly (by looking throgh all the vrms_data.json file), despite not making changes to the code:

onboarding - new prosp. members
home unite us - all
civic tech jobs - all
civic tech jobs - pm/org
food oasis - all
la tdm calculator - stakeholder
food oasis - uxr team
311 data - leads
expunge assist - all
expunge assist - pm/org
civic tech jobs - leads

@terrencejihoonjung terrencejihoonjung self-assigned this Jun 15, 2024
Copy link

Hi @terrencejihoonjung, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@terrencejihoonjung
Copy link
Member

ETA: 6/17/24, 11:59pm PST
Availability: 7pm - 12am PST, everyday

@terrencejihoonjung
Copy link
Member

  1. Progress: I've modified the JSON file to include a "isWeekly" key with their corresponding boolean value. I've also implemented conditional rendering of the asterisk depending on whether isWeekly is false.
  2. Blockers: I'm having some issues with isWeekly showing up as "undefined" even though the JSON file is valid and contains the appropriate data. My docker is also displaying the website in the incorrect format, so I will have to go to office hours to fix that u
  3. Availability: 7pm - 12am PST, everyday
  4. ETA: 6/21/24, 11:59pm PST

@t-will-gillis
Copy link
Member

Reopening this issue: The previous solution relies on direct edits to vrms-data.json. These edits are over-written by the daily workflow run of "Update VRMS Data".

@t-will-gillis t-will-gillis reopened this Jul 2, 2024
@t-will-gillis
Copy link
Member

@terrencejihoonjung Please let us know if you would like to keep working on this issue- thanks!

@terrencejihoonjung
Copy link
Member

updated ETA: 7/3/24, 11:59pm PST
updated availability: 7pm - 12am PST, weekdays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment