-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ER: update the pull request contributing guidelines #6990
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Hi @DrAcula27, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
Availability: weekdays after 3pm Pacific |
@t-will-gillis The issue for this ER has been made. Let me know if there are any questions/concerns! |
Closing this ER, issue #7641 has been made to address it |
Emergent Requirement - Problem
This problem was brought up during the weekly Sunday meeting on 06/09/24.
We want the title of the PR to clearly summarize how the dev resolved the issue. When devs unnecessarily include the issue number in the title, the issue number collides with the PR number making it unclear which is which, and is a detriment to clear communication. Here is an example:
Issue you discovered this emergent requirement in
Date discovered
Did you have to do something temporarily
Who was involved
@ino-iosdev
@t-will-gillis
What happens if this is not addressed
Resources
CONTRIBUTING.md#part-3-pull-requests
Recommended Action Items
Potential solutions [draft]
In CONTRIBUTING.md, Section 3.1.b.i. Replace:
with:
The text was updated successfully, but these errors were encountered: