Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: Modify "Update Label Directory" workflow to recover from accidental deletion #7883

Closed
2 of 5 tasks
t-will-gillis opened this issue Feb 4, 2025 · 1 comment
Closed
2 of 5 tasks
Labels
Complexity: Large Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 8pt Can be done in 31-48 hours

Comments

@t-will-gillis
Copy link
Member

t-will-gillis commented Feb 4, 2025

Emergent Requirement - Problem

Whenever a label is deleted (accidentally or not) from the repo, the label gets removed from all issues that previously had that label. Creating a new label with the same name does not recover those issues- this information is lost. We need a mechanism to either re-apply labels when they are deleted from the repo, and/or notify us that this has happened.

On Jan 20th, a dev deleted the 2 weeks inactive label. The label was removed from over 20 issues. When the "Schedule Friday" automation ran 5 days later, it appears that the bot created a replacement label. However, the replacement is unique and does not equate to the original label.

Issue you discovered this emergent requirement in

Date discovered

2/3/25

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@t-will-gillis

What happens if this is not addressed

In this case, 24 issues were un-labeled without us knowing. This will break / cause an error in the label automations when those are active.

Resources

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

  • IMPORTANT: need to sync the "NEW-2 weeks inactive" label key with "2 weeks inactive" previous/deleted key
  • As can be seen from the screenshot, after the label is deleted the bot removes it from each issue- and this activity is being captured by the existing automations. Therefore we should be able to use the existing automations to:
    • list each issue that is unlabeled due to the deletion
    • generate an issue that informs us that the label has been deleted
    • (optionally) automatically regenerate the label- or at least ask if we would like to do that
    • (optionally) automatically re-apply the label to the listed issues
Workflow logs showing initiating action, label deletion, and label removal ('unlabeled')

Image

@t-will-gillis t-will-gillis added Complexity: Large Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 8pt Can be done in 31-48 hours labels Feb 4, 2025
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: HfLA Website: Project Board Feb 4, 2025
@t-will-gillis
Copy link
Member Author

@github-project-automation github-project-automation bot moved this from New Issue Approval to QA in P: HfLA Website: Project Board Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 8pt Can be done in 31-48 hours
Projects
Development

No branches or pull requests

1 participant