🔧 fix(#75): make validator accept null values.

Author: hackingharold

.github/workflows/on-pull-request.yml

@@ -11,7 +11,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: oven-sh/setup-bun@v1
-      - run: bun install
+      - run: bun install --frozen-lockfile
 
       - run: bun run lint:cdk
       - run: bun run build:cdk
@@ -22,7 +22,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: oven-sh/setup-bun@v1
-      - run: bun install
+      - run: bun install --frozen-lockfile
 
       - run: bun run build:cdk
       - run: bun run lint:material

.github/workflows/on-release.yml

@@ -19,7 +19,7 @@ jobs:
           always-auth: true
           token: ${{ secrets.NPM_TOKEN }}
       - uses: oven-sh/setup-bun@v1
-      - run: bun install
+      - run: bun install --frozen-lockfile
 
       - run: bun run build:cdk
       - run: bun run build:material

bun.lockb

@@ -41,6 +41,7 @@
     "@types/node": "^20.5.9",
     "@typescript-eslint/eslint-plugin": "^6.10.0",
     "@typescript-eslint/parser": "^6.10.0",
+    "ajv": "^8.12.0",
     "eslint": "^8.53.0",
     "jasmine-core": "~3.8.0",
     "karma": "~6.4.2",

package.json

@@ -16,8 +16,8 @@ export class DropzoneService {
 
     const fsEntries = Array.from(event.dataTransfer?.items ?? [])
       .map((item) => this._toFileSystemEntry(item))
-      .filter(nonNullable)
-      .map((entry) => this._getFilesFromEntry(entry));
+      .map((entry) => this._getFilesFromEntry(entry))
+      .filter(nonNullable);
 
     const files: File[][] = await Promise.all(fsEntries);
     return this._flattenFiles(files);
@@ -34,7 +34,9 @@ export class DropzoneService {
     return item.webkitGetAsEntry() || item.getAsFile();
   }
 
-  private async _getFilesFromEntry(entry: FileSystemEntry | File): Promise<File[]> {
+  private async _getFilesFromEntry(entry: FileSystemEntry | File | null): Promise<File[]> {
+    if (!entry) return [];
+
     if (entry instanceof File) {
       return [entry];
     }

projects/cdk/src/lib/dropzone/dropzone.service.ts

@@ -11,7 +11,7 @@ describe('AcceptService', () => {
     getFile('doc', 'application/msword'),
     getFile('docx', 'application/msword'),
     getFile('txt'),
-    getFile('pdf', 'application/octet-stream')
+    getFile('pdf', 'application/octet-stream'),
   ];
 
   beforeEach(() => {
@@ -55,8 +55,8 @@ describe('AcceptService', () => {
     expect(accepted).toBeTrue();
   });
 
-  it('should not accept null', () => {
-    const accepted = service.accepts(null, '*');
-    expect(accepted).toBeFalse();
+  it('should skip filter on null', () => {
+    const accepted = service.accepts(null, 'image/png');
+    expect(accepted).toBeTrue();
   });
 });

projects/cdk/src/lib/file-input/accept.service.spec.ts

@@ -11,11 +11,7 @@ export class AcceptService {
    * for more information.
    */
   accepts(fileValue: FileInputValue, accept: string): boolean {
-    if (!fileValue) {
-      return false;
-    }
-
-    if (accept === '*') {
+    if (!fileValue || accept === '*') {
       return true;
     }