Skip to content

Commit f3ee9e0

Browse files
authored
Merge pull request #68 from hacks/mobile-comfort
Added mobile & accessible changes
2 parents 76314ec + 24abcf5 commit f3ee9e0

File tree

8 files changed

+70
-53
lines changed

8 files changed

+70
-53
lines changed

src/assets/speech-bubble.svg

Lines changed: 1 addition & 1 deletion
Loading

src/components/hacks-nav.vue

Lines changed: 29 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,16 @@
11
<template>
22
<div class="hacks-nav">
33
<div class="hacks-nav__container" v-if="!isMobile">
4-
<router-link v-for="r in routes" :key="r.path" :to="r.path">{{ r.name }}</router-link>
4+
<router-link v-for="r in routes" :key="r.path" :to="r.path">{{
5+
r.name
6+
}}</router-link>
57
</div>
68

7-
<div class="hacks-nav__button" v-if="isMobile" @click="menuOpen = !menuOpen">
9+
<div
10+
class="hacks-nav__button"
11+
v-if="isMobile"
12+
@click="menuOpen = !menuOpen"
13+
>
814
<h2>≡</h2>
915
</div>
1016

@@ -37,26 +43,26 @@ import { routes } from "../router";
3743
export default {
3844
name: "hacks-nav",
3945
components: {
40-
HacksModal
46+
HacksModal,
4147
},
4248
props: {
4349
isMobile: {
4450
type: Boolean,
4551
required: true,
46-
default: false
47-
}
52+
default: false,
53+
},
4854
},
4955
data() {
5056
return {
5157
menuOpen: false,
52-
routes: routes
58+
routes: routes,
5359
};
5460
},
5561
methods: {
5662
closeModal() {
5763
this.menuOpen = !this.menuOpen;
58-
}
59-
}
64+
},
65+
},
6066
};
6167
</script>
6268

@@ -67,22 +73,23 @@ export default {
6773
font-variant: small-caps;
6874
text-transform: lowercase;
6975
font-weight: lighter;
70-
width: $hacks-page-width;
7176
display: block;
7277
margin: auto;
78+
width: fit-content;
7379
7480
&__button {
75-
line-height: 48px;
7681
cursor: pointer;
7782
display: block;
7883
width: 100vw;
84+
line-height: 3em;
7985
top: 0;
8086
right: 0;
8187
8288
h2 {
8389
margin: unset;
8490
text-align: right;
85-
font-size: 108px !important;
91+
padding-right: 0.1em;
92+
font-size: $hacks-hamburger-size;
8693
}
8794
}
8895
@@ -92,14 +99,17 @@ export default {
9299
list-style-type: none;
93100
display: block;
94101
margin: 15vh auto;
95-
font-size: 72px;
102+
font-size: $hacks-mobile-menu-text;
103+
104+
> li {
105+
padding: 1em 0;
106+
}
96107
}
97108
98109
a {
99110
position: relative;
100111
text-decoration: none;
101112
font-weight: 900;
102-
size: 14px !important;
103113
color: $hacks-nav-inactive-color !important;
104114
font-size: $hacks-h2;
105115
padding: 0.5em;
@@ -113,8 +123,7 @@ export default {
113123
&:not(.router-link-exact-active) {
114124
@keyframes focusin {
115125
from {
116-
text-shadow: 3px 3px rgba($color: red, $alpha: 0.4),
117-
-3px -3px rgba($color: cyan, $alpha: 0.4);
126+
text-shadow: $hacks-three-dee;
118127
}
119128
to {
120129
text-shadow: unset;
@@ -130,10 +139,15 @@ export default {
130139
&__container {
131140
display: flex;
132141
flex-wrap: wrap;
142+
width: $hacks-page-width;
133143
align-items: baseline;
134144
margin: unset;
135145
margin-top: 1em;
136146
147+
@media (max-width: $hacks-page-width) {
148+
width: 80vw;
149+
}
150+
137151
:nth-child(1) {
138152
padding-left: unset;
139153
}

src/styles/_default.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
.hacks {
22
&-small-caps {
3-
font-size: $hacks-text;
3+
font-size: $hacks-small-caps-size;
44
font-weight: $hacks-small-caps-weight;
55
font-variant: small-caps;
66
text-transform: lowercase;

src/styles/_variables.scss

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,33 @@
11
// Text
2-
$hacks-h1: 48px;
3-
$hacks-h2: 36px;
4-
$hacks-text: 24px;
2+
$hacks-h1: 3em;
3+
$hacks-h2: 2em;
4+
$hacks-text: 1.5em;
55
$hacks-text-spacing: 2em;
6+
$hacks-small-caps-size: 2.2em;
67
$hacks-small-caps-weight: 600;
8+
$hacks-hamburger-size: 8em;
9+
$hacks-mobile-menu-text: em(72px);
710

811
$hacks-border: 5px dotted rgba(white, 0.5);
12+
$hacks-three-dee: 3px 3px
13+
rgba(
14+
$color: red,
15+
$alpha: 0.4,
16+
),
17+
-3px -3px
18+
rgba(
19+
$color: cyan,
20+
$alpha: 0.4,
21+
);
22+
$hacks-title-three-dee: 2px 0px
23+
rgba(
24+
$color: red,
25+
$alpha: 0.4,
26+
),
27+
-2px 0px rgba(
28+
$color: cyan,
29+
$alpha: 0.4,
30+
);
931

1032
// Sizes
1133
$hacks-page-width: 981px;

src/views/About.vue

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@
1616
is. Here are some that we think are memorable:
1717
</p>
1818
<ul>
19-
<li>
20-
Hacks is a place where cool people build cool stuff because it's cool
21-
</li>
19+
<li>Hacks is a place where cool people build cool stuff because it's cool</li>
2220
<li>Tech tastemakers</li>
2321
<li>We sit around and watch train videos</li>
2422
<li>Social club for nerds</li>
@@ -29,14 +27,16 @@
2927
</ul>
3028
<p>
3129
If you want to add your own description come to a hacks meeting or email
32-
<a href="mailto:eboard@nuhacks.io">eboard@nuhacks.io</a>
30+
<a
31+
href="mailto:eboard@nuhacks.io"
32+
>eboard@nuhacks.io</a>
3333
</p>
3434
</section>
3535
</template>
3636

3737
<script>
3838
export default {
39-
name: "hacks-about",
39+
name: "hacks-about"
4040
};
4141
</script>
4242

@@ -66,7 +66,6 @@ export default {
6666
6767
li:before {
6868
content: "";
69-
font-size: 18px;
7069
vertical-align: top;
7170
padding-right: 1em;
7271
}

src/views/EBoard.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ export default {
145145
146146
&__position {
147147
opacity: 0.7;
148-
width: 10em;
149148
word-wrap: break-word;
150149
}
151150

src/views/Home.vue

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
</em>
1818
</p>
1919

20-
<div class="hacks-homepage__email">
20+
<div>
2121
<span class="hacks-small-caps">Questions?</span>
2222
<p>Email us at eboard@nuhacks.io</p>
2323
</div>
@@ -50,13 +50,13 @@
5050
<hacks-button
5151
link="https://nuhacks.us4.list-manage.com/subscribe?u=cbcce83bcf3543d25bd103865&id=6c0da9d34e"
5252
>
53-
<img src="../assets/mail.svg"/>
53+
<img src="../assets/mail.svg" />
5454
<h3>Mailing List</h3>
5555
</hacks-button>
5656
<hacks-button
5757
link="https://join.slack.com/t/nuhacks/shared_invite/zt-fgvmdpo1-KzxoPn2ematExVMDKEK1zQ"
5858
>
59-
<img src="../assets/slack-black.svg">
59+
<img src="../assets/slack-black.svg" />
6060
<h3>Slack</h3>
6161
</hacks-button>
6262
</div>
@@ -73,8 +73,8 @@ export default {
7373
name: "hacks-homepage",
7474
components: {
7575
HacksButton,
76-
HacksAnnounce
77-
}
76+
HacksAnnounce,
77+
},
7878
};
7979
</script>
8080

@@ -88,27 +88,19 @@ export default {
8888
}
8989
9090
&__slogan {
91-
width: 500px;
91+
width: 600px;
9292
line-height: $hacks-text-spacing;
93-
94-
@media (max-width: 500px) {
95-
width: 100%;
96-
}
97-
}
98-
99-
&__email {
100-
padding-left: 3em;
93+
margin-right: 1em;
94+
margin-bottom: 1em;
10195
}
10296
10397
&__join {
10498
font-weight: $hacks-small-caps-weight;
105-
font-size: 36px !important;
10699
padding-left: 0.3em;
107100
}
108101
109102
&__title {
110-
text-shadow: 2px 0px rgba($color: red, $alpha: 0.4),
111-
-2px 0px rgba($color: cyan, $alpha: 0.4);
103+
text-shadow: $hacks-title-three-dee;
112104
color: rgba($color: white, $alpha: 0.7);
113105
}
114106

src/views/Members.vue

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -90,14 +90,6 @@ export default {
9090
flex-flow: row wrap;
9191
}
9292
93-
&__ccs {
94-
display: block;
95-
margin: auto;
96-
color: $hacks-background-color;
97-
font-size: 18px;
98-
text-transform: uppercase;
99-
}
100-
10193
&__member {
10294
margin: 1em;
10395
margin-left: unset;
@@ -121,7 +113,6 @@ export default {
121113
content: ">";
122114
padding-right: 1em;
123115
vertical-align: top;
124-
font-size: 18px;
125116
}
126117
}
127118
}

0 commit comments

Comments
 (0)