Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all form validation to the backend #942

Open
dhess opened this issue Jun 4, 2023 · 0 comments
Open

Move all form validation to the backend #942

dhess opened this issue Jun 4, 2023 · 0 comments
Labels
backend Affects/is affected by the backend service enhancement New feature or request UX UX issue

Comments

@dhess
Copy link
Member

dhess commented Jun 4, 2023

Because it creates better UX, we do some client-side form validation, such as stripping blank space off definition names in the CreateDefModal form. However, in an upcoming PR, we'll also check for duplicate names in the typedef and definition namespaces, again because this provides better UX. This is a rare occasion where the frontend makes assumptions about the language's semantics, which is something we try to avoid, in general.

We should fix this, either by not dismissing the form until the backend has returned a 2xx status code upon submission, or possibly via some sort of websocket validation mechanism.

@dhess dhess added backend Affects/is affected by the backend service enhancement New feature or request UX UX issue labels Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Affects/is affected by the backend service enhancement New feature or request UX UX issue
Projects
None yet
Development

No branches or pull requests

1 participant