-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Redownload non-default branch #3280
Comments
Make sure you have read the issue guidelines and that you filled out the entire template. If you have an issue identical to this, do not add comments like "same here", "i have this too", instead add a 👍 reaction to the issue description. Thanks! 👍 |
I’m currently not taking feature requests (which is why you did not find a place for it). |
Thanks for the response - apologies for not knowing that you aren't taking feature requests 😳 Just to clarify, when you say "will come" - does that mean this is an upcoming feature already planned in HACS, or just a note about what it would take in order to achieve that? Or is that something that is already possible but I've just missed it somewhere? Not fully understanding, and on the hope that it means the latter, I tried to call So I guess that leaves the other two options: is that something that is planned, or was that comment just an FYI? |
It is planed to be implemented I just have not yet gotten around to actually do it yet. |
Awesome! Thanks for the quick response. |
FYI: #3301 |
System Health details
System Information
Home Assistant Community Store
Home Assistant Cloud
Home Assistant Supervisor
Dashboards
Recorder
Spotify
Checklist
Describe the issue
This idea is inspired by the way the ESPHome supports
external_components
configuration, particularly being able to link directly to a GitHub PR:Today when you select a repository > ⋮ > Redownload, you are presented with a couple possible views:
main
).main
) if beta is checked.What would be useful is an additional option here - maybe only if advanced/experimental features are enabled, and maybe only if the "beta" checkbox was enabled - to select or enter a PR # to use, or list other branches aside from the default branch (could be limited as well, to avoid overwhelming the UI for active projects).
The goal would be for an integration author to prepare a new branch (and maybe even create the PR from it) and ask for testers in the original issue or PR. Users would be able to test it quickly just by entering the PR number, or selecting or entering the test branch name. From there, same rules apply (restart required, and so on). The user tests the functionality, reports results back to the issue or PR, and then the user can go back and switch back to the default branch or the latest version and wait for the fix to land.
I did see one discussion about this on Discord from Mar 2023, where your feedback was that it should not be used for temporary things. I understand not wanting to potentially leave users in a bad or orphaned spot, but the alternative options are actually more error prone IMO:
main
branch for one-off testing. For repos that are not highly active, this is probably the cleanest approach, but it comes at the expense of writing possibly broken commits into the main branch, which is also poor git-etiquette (and/or amending commits and force-pushing, which is also poor git-etiquette).Note: I read the Issues page, and also looked over the available templates, but unfortunately I did not see any information about "feature request" issues. So, apologies if this is insufficient for a feature request, feature requests are not accepted, or if feature requests are meant to go someplace else 😬
Reproduction steps
Debug logs
Diagnostics dump
No response
The text was updated successfully, but these errors were encountered: