Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for custom AppDaemon apps #77

Closed
apop880 opened this issue Jun 11, 2019 · 12 comments
Closed

Request for custom AppDaemon apps #77

apop880 opened this issue Jun 11, 2019 · 12 comments

Comments

@apop880
Copy link
Contributor

apop880 commented Jun 11, 2019

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
One benefit of AppDaemon that I think is underutilized is how reusable and shareable apps are. I think a lot of Home Assistant users are put off by the learning curve of learning Python to use AppDaemon. However, it's very possible for people to create apps that anyone can use without modifying the underlying Python code, that just take some YAML configuration to set up. It would be great to be able to have a section in HACS, in addition to custom components and Lovelace plugins, for custom AppDaemon apps that could auto update.

Describe alternatives you've considered
If this isn't something you're interested in implementing with HACS, I've looked at some other options for having apps auto update, but I think this would be the cleanest route and would put everything custom in one interface.

Additional context
Apps would land in the appdaemon/apps/<app_name> folder. And I think it would be possible to pull the suggested YAML configuration out and include it in HACS like Lovelace plugins do.

Also, I would be happy to take this on myself and put in a PR. But I wanted to run the idea by you before I start any work on it to see if it's something you'd be willing to merge or implement.

@ludeeus
Copy link
Member

ludeeus commented Jun 12, 2019

I need to do a lot of research, before starting on this one.

Do you have any example repositories for AD apps?

Is the suggested local location the official suggestion from AD?

@apop880
Copy link
Contributor Author

apop880 commented Jun 12, 2019

I don't know that there are a ton of examples of repos specifically designed for shareable scripts. But here's an example of one with a number of scripts:
https://github.com/eifinger/appdaemon-scripts

Here's my repo, pretty basic at the moment but both scripts in there are completely designed to be used as-is, with only YAML configuration needed:
https://github.com/apop880/AppDaemon

I feel like there isn't really a standard at the moment for this, but I think having something standardized like HACS available would encourage more "ready-to-use" scripts to be developed.

Every configuration I've seen posted on github has AD apps in /config/appdaemon/apps, but you're right that it's not a hard and fast rule. Would probably need to make that user-configurable in HACS.

Like I said, I have a couple other ideas in mind that would work to do this outside of HACS, but if you're interested in the idea I feel like leveraging the framework that's already been built here makes sense.

@ludeeus
Copy link
Member

ludeeus commented Jun 12, 2019

I would love to have AD in there to, I did some research to have it in custom_updater, but it could not find any clear standard.

I could probably force the user to use that local dir for as one of the requirements, making an option would be too much that can go wrong.

But the biggest issue:
HACS is built around the premise of one element PR repository, this will not change.

For now I don't think the AD community is ready for a change like that, I'm not even sure it would make sense

@apop880
Copy link
Contributor Author

apop880 commented Jun 12, 2019

That's a good point, since a typical AD app can be pretty small, a lot of people just store their apps as one big repo with every app in an individual folder. One repo per app feels like it would be overkill, but anything else would require more re-architecture on the HACS side.

For now, I'll probably continue to explore what other options might be available, then.

@ludeeus
Copy link
Member

ludeeus commented Jun 12, 2019

The same requirements apply to Lovelace plugins as well, some of those are only a couple of lines, but there most plugins are in a dedicated repository.

So it could work for AD to, but for now I don't see that happening in that community, I may be wrong.
And like I said I would be happy to have it there, but before we get that far there has to be a "market" for it :/

@apop880
Copy link
Contributor Author

apop880 commented Jun 12, 2019

That makes total sense! I will try and put out some feelers on the forum and see what the community's interest level is.

@ludeeus
Copy link
Member

ludeeus commented Jun 12, 2019

@bbrendon
Copy link

Lots of apps here.
https://github.com/topics/appdaemon

@ludeeus
Copy link
Member

ludeeus commented Jun 18, 2019

@apop880 sample structure: https://github.com/ludeeus/ad-hacs
Does this seam doable?

@apop880
Copy link
Contributor Author

apop880 commented Jun 19, 2019

So that's a sample in terms of how a repo for an app would be laid out? If so, I think that looks great!

@ludeeus
Copy link
Member

ludeeus commented Jun 19, 2019

Correct 👍

@ludeeus
Copy link
Member

ludeeus commented Jun 22, 2019

Implemented in 0.9.0 🎉

@ludeeus ludeeus closed this as completed Jun 22, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants