Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

.NET 5 support #213

Closed
laurentkempe opened this issue Nov 10, 2020 · 14 comments · Fixed by #214
Closed

.NET 5 support #213

laurentkempe opened this issue Nov 10, 2020 · 14 comments · Fixed by #214

Comments

@laurentkempe
Copy link

Thanks for DotNetZip ❤️

I am trying to update our application to .NET 5 and I am facing the following issue:

DotNetZip 1.14.0 -> System.Security.Permissions (>= 4.5.0 && < 5.0.0).
System.Configuration.ConfigurationManager 5.0.0 -> System.Security.Permissions (>= 5.0.0)

So, I would like to know if there is a plan to relax the package bound to include 5.0.0?

@gokhanabatay
Copy link

Hi could you please add support .net 5, I have been encountered same issue with System.* namespaces

@MarvinKlein1508
Copy link

Yes. Please add support for .NET 5

@laurentkempe
Copy link
Author

@haf I had a quick look into paket and my understanding is that what is needed it to run a paket update! I could propose a PR, but I would like to be sure what needs to be done? Thanks for your help

@haf
Copy link
Owner

haf commented Nov 11, 2020

@laurentkempe That may be it, I don't know 100%. I'd think you need to update the paket software's version as well.

@lahma lahma mentioned this issue Nov 11, 2020
@digitalsigi
Copy link

Great package! Thx a lot.
Yes, please add support for .NET 5.

@lahma
Copy link
Contributor

lahma commented Nov 11, 2020

I created a PR which might solve this issue #214

@digitalsigi
Copy link

I created a PR which might solve this issue #214

I just saw it. but have no idea how to try it. I created a fork, but left it aside, because I am working on a rather large project and was able to isolate this package for the moment. However, if you could give me some help/guidance to try it in a asp net core project, I am willing to give it a chance,

@lahma
Copy link
Contributor

lahma commented Nov 11, 2020

@laurentkempe
Copy link
Author

@digitalsigi You can download it from artifacts https://ci.appveyor.com/project/haf/dotnetzip-semverd/builds/36257761/artifacts

I will try it a bit later and let you know!

@digitalsigi
Copy link

Thx. Downloaded it and tried ton install, but got an error, herer des messages unfortunately in german:

PS C:\GITatUHU\rvsweb\src\avsweb.ZIP> dotnet add package "C:\Users\jbogad\Downloads\DotNetZip.1.15.0.nupkg" -s local
Wiederherzustellende Projekte werden ermittelt...
Writing C:\Users\jbogad\AppData\Local\Temp\tmpDD88.tmp
info : Die PackageReference für das Paket "C:\Users\jbogad\Downloads\DotNetZip.1.15.0.nupkg" wird dem Projekt "C:\GITatUHU\rvsweb\src\avsweb.ZIP\avsweb.ZIP.csproj" hinzugefügt.
info : GET https://api.nuget.org/v3/registration5-gz-semver2/c:/users/jbogad/downloads/dotnetzip.1.15.0.nupkg/index.json
info : GET http://nuget/nuget/FindPackagesById()?id='C%3A%5CUsers%5Cjbogad%5CDownloads%5CDotNetZip.1.15.0.nupkg'&semVerLevel=2.0.0
info : OK http://nuget/nuget/FindPackagesById()?id='C%3A%5CUsers%5Cjbogad%5CDownloads%5CDotNetZip.1.15.0.nupkg'&semVerLevel=2.0.0 33 ms
info : NotFound https://api.nuget.org/v3/registration5-gz-semver2/c:/users/jbogad/downloads/dotnetzip.1.15.0.nupkg/index.json 612 ms
info : GET https://api.nuget.org/v3/registration5-gz-semver2/c:/users/jbogad/downloads/dotnetzip.1.15.0.nupkg/index.json
info : CACHE http://nuget/nuget/FindPackagesById()?id='C%3A%5CUsers%5Cjbogad%5CDownloads%5CDotNetZip.1.15.0.nupkg'&semVerLevel=2.0.0
info : NotFound https://api.nuget.org/v3/registration5-gz-semver2/c:/users/jbogad/downloads/dotnetzip.1.15.0.nupkg/index.json 198 ms
error: Für das Paket "C:\Users\jbogad\Downloads\DotNetZip.1.15.0.nupkg" sind keine Versionen verfügbar.

@laurentkempe
Copy link
Author

Thanks @lahma No more issues for me with that version 👏 I can update System.Configuration.ConfigurationManager to 5.0.0 now without conflicts!

@digitalsigi your command is wrong, I think, try with

dotnet add package DotNetZip -s C:\Users\jbogad\Downloads\ -v 1.15.0

@digitalsigi
Copy link

Can confirm it works.

@gokhanabatay
Copy link

Thanks @lahma No more issues for me with that version 👏 I can update System.Configuration.ConfigurationManager to 5.0.0 now without conflicts!

Hi @laurentkempe when will you plan to update nuget package?

@laurentkempe
Copy link
Author

laurentkempe commented Nov 12, 2020

Hi @gokhanabatay I am not the maintainer of this project. I just reported the issue and proposed to try to fix it. But @lahma was super fast on fixing it, so I guess we have to wait that he merges the PR and then someone has to upload the nuget.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants