Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange characters when running expecto's template project #145

Closed
Kurren123 opened this issue Apr 25, 2017 · 16 comments
Closed

Strange characters when running expecto's template project #145

Kurren123 opened this issue Apr 25, 2017 · 16 comments

Comments

@Kurren123
Copy link

Steps to reproduce

Go to a new folder

dotnet new -i Expecto.Template::5.0.0-beta1
dotnet new expecto
dotnet restore
dotnet build
dotnet run

Output

Strange characters are next to the last line:

[11:05:37 INF] EXPECTO! 8 tests run in 00:00:00.2364089 ÔÇô 2 passed, 1 ignored, 5 failed, 0 errored. ( Ó▓░ ─╣╠» Ó▓░Ó│â )

Screenshot:

image

System info

  • Windows 10
  • Dotnet version 1.0.0
@forki
Copy link
Contributor

forki commented Apr 25, 2017

@haf calls that "spirit" and it's supposed to be something like an emoji / smiley. Unfortunately it often just looks weird. I tried to PR it out but @haf insisted it stays ;-(

@MNie
Copy link
Contributor

MNie commented Apr 25, 2017

@Kurren123 it's a rather related to encoding/font in your cmd?
@forki It's related to Expecto.Template I could remove this emoji / smiley from Expecto.Template samples file.

@vasily-kirichenko
Copy link

I'm also for removing this unicode noise. If not @forki I'd never recognized a smile there.

@Kurren123
Copy link
Author

@MNie i don't think its related to the template because when I replace the tests with my own simple test I still get the issue

@forki
Copy link
Contributor

forki commented Apr 25, 2017

@MNie no the template is unrelated nonsense ;-)

@Kurren123
Copy link
Author

@MNie Is this a problem with my specific cmd? I'm guessing you can see the smiley on linux but not windows

@forki
Copy link
Contributor

forki commented Apr 25, 2017

@Kurren123 yes there are situations where the console shows the intended chars, but even then some peope (like me) can't see that it is supposed to be a smiley.

@MNie
Copy link
Contributor

MNie commented Apr 25, 2017

@MNie no the template is unrelated nonsense ;-)
@forki I looked at first at steps to reproduce my mistake ;)

@forki
Copy link
Contributor

forki commented Apr 25, 2017

@MNie I was obviously joking a bit, but I'd prefer we remove spritis from templates and product

@haf
Copy link
Owner

haf commented Apr 25, 2017

@Kurren123 There are UTF8 capable terminals in the world, even on Windows. The spirit is this one:

ᕙ໒( ˵ ಠ ╭͜ʖ╮ ಠೃ ˵ )७ᕗ

@forki
Copy link
Contributor

forki commented Apr 25, 2017

doesn't look any different to me.

@haf
Copy link
Owner

haf commented Apr 25, 2017

There are arms at the start and end and a monocle on the right eye?

@forki
Copy link
Contributor

forki commented Apr 25, 2017

and a bit of snot in the nose?

@Kurren123
Copy link
Author

@haf yes the command prompt is pretty basic so it's a good idea to use something else. However the same bug appears on the terminal within vscode also:

image

I actually like the smiley, it's just the jumbled characters that look messy

@haf
Copy link
Owner

haf commented Apr 25, 2017

@Kurrren123 – that's a bug in VSCode and/or the terminal emulator it uses.

@adamchester
Copy link
Contributor

adamchester commented Apr 25, 2017

I haven't dug into this yet, but this recent change might be related bc3a172#diff-312b950ecb6e71200586b2408ab6e821R643

@haf haf closed this as completed in 8e84738 Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants