Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for secure websockets #201

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

Niek
Copy link
Collaborator

@Niek Niek commented May 28, 2020

Related Issue (if applicable): #195

Description:

This PR adds support for secure websockets. This is very useful when running obs-websocket behind a proxy like ngrok. This allows OBS to be controlled from HTTPS websites.

@Niek
Copy link
Collaborator Author

Niek commented May 28, 2020

Sample code:

await obs.connect({ address, password, secure: (location.protocol === 'https:') });

@Niek
Copy link
Collaborator Author

Niek commented Jun 10, 2020

@haganbmj can you merge this?

@chmaltsp
Copy link

Would love to see this merged as well

@Niek
Copy link
Collaborator Author

Niek commented Sep 3, 2020

@haganbmj are you still maintaining this?

@rodrigograca31
Copy link
Contributor

rodrigograca31 commented Sep 23, 2020

Looks like good code.

The maintainer is not responsive at the moment... I also have a PR waiting...

@haganbmj
Copy link
Collaborator

Sorry, you're correct that I haven't been actively maintaining this. Did obs-websocket add support for wss? I haven't looked at that either in a while.

At some point in the past I stopped using OBS regularly and my interest waned. I had handed it off to Lange when they seemed adamant that adding typings to this was beneficial, but I think he might be inactive as well. I can merge this, but I'll also need to go through and check if the test + deploy jobs are working - I wouldn't be surprised if some of my access tokens for npm expired.

@haganbmj haganbmj merged commit c080ca7 into obs-websocket-community-projects:master Sep 24, 2020
@haganbmj
Copy link
Collaborator

Oh just reread your post about deploying behind ngrok, gotcha now on when wss is an option.
Merged and trying a release job now.

@haganbmj
Copy link
Collaborator

image

Eh, npm looks happy enough.
I'll have a look through the other PRs, including yours Rodrigo.

@Niek
Copy link
Collaborator Author

Niek commented Sep 24, 2020

Excellent, thanks a lot @haganbmj

If you don't have time to maintain the repo I'd be happy to help you out. I'm depending on this library in my https://github.com/Niek/obs-web repo

@rodrigograca31
Copy link
Contributor

@haganbmj thanks for your hard work!

I'm also happy to be a contributor and help. That's why I commented on this thread yesterday: 😅
I'm already a contributor to many open-source projects and npm package publisher.


@Niek Didn't know about your project! Looks super nice!
I've used your "competition" (t2t2/obs-tablet-remote) 😂 😂
because they are linked in the main obs-websocket project. You should get yours linked there too! Shall I send them a PR?

@Niek
Copy link
Collaborator Author

Niek commented Sep 24, 2020

Thanks @rodrigograca31 - yes if you can do a PR there that would be nice.

@rodrigograca31
Copy link
Contributor

done. obsproject/obs-websocket#592

@Niek
Copy link
Collaborator Author

Niek commented Mar 30, 2021

@haganbmj let me know if me or @rodrigograca31 can help with maintaining this repo. It would be nice to get some PRs merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants