Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize the experimental crypto.* functions #1416

Open
hairyhenderson opened this issue Jun 1, 2022 · 3 comments
Open

Finalize the experimental crypto.* functions #1416

hairyhenderson opened this issue Jun 1, 2022 · 3 comments
Assignees
Milestone

Comments

@hairyhenderson
Copy link
Owner

I've marked most of the crypto.* functions (https://docs.gomplate.ca/functions/crypto) that have to do with encrypting/decrypting or key generation as experimental, because I feel like it may be possible to have a cleaner more unified syntax for these.

Naming-wise the functions are inconsistent (e.g. crypto.RSAEncrypt vs crypto.EncryptAES), and in general it feels like it might feel "cleaner" to just call crypto.Encrypt with appropriate arguments.

Currently only RSA and AES encryption are supported for [en|de]cryption, but it may make sense to support more algorithms like XChaCha20-Poly1305...

Perhaps signatures like this make sense:

crypto.Encrypt [algo] key [keyBits] input
crypto.Decrypt [algo] key [keyBits] input

Inferring algo is simple between RSA/AES, but a bit more complicated once other algorithms come into play 🤔

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

This issue is stale because it has been open for 60 days with no activity. Remove stale label or comment or this will be automatically closed in a few days.

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

This issue is stale because it has been open for 60 days with no activity. Remove stale label or comment or this will be automatically closed in a few days.

@github-actions github-actions bot added the Stale label Jun 5, 2023
@hairyhenderson hairyhenderson added this to the v4.0.0 milestone Jun 26, 2023
@hairyhenderson hairyhenderson modified the milestones: v4.0.0, v4.1.0 May 12, 2024
@hairyhenderson
Copy link
Owner Author

I've moved this out to target v4.1.0 (the first minor after 4.0), as this isn't a breaking change (since these are experimental) and I still haven't had time to look closer at this.

@hairyhenderson hairyhenderson modified the milestones: v4.1.0, v4.3.0 Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant