Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seadrive accidentally deletes files that have yet to be synced when clicking "Free up space" #1446

Open
pmdevita opened this issue Mar 4, 2023 · 4 comments

Comments

@pmdevita
Copy link

pmdevita commented Mar 4, 2023

This issue occurred for me on Windows 10, I don't know about other platforms but considering this seems to be an issue with the sync logic, I would suspect a similar problem could occur.

Steps to reproduce

  1. Copy a folder with a lot of files into a Seadrive share
  2. After some of the files inside the folder have synced, right click on the parent folder and select "Free up space"
  3. Seadrive will then remove all of the files from the folder, including files that have yet to be synced, effectively deleting them, and causing confusion between the server and client.

Seadrive then reports errors in it's log like this

[03/03/23 02:45:32] dir parent_folder/subfolder doesn't exist in repo repohash.
[03/03/23 02:45:32] Failed to get path parent_folder/subfolder/image.jpg for repo repohash.

I think a check should be added to ensure all files have been synced to the server before freeing it, or that only files synced to the server should be freed.

@pmdevita pmdevita changed the title Seadrive accidentally deletes files that have yet to be sync when clicking "Free up space" Seadrive accidentally deletes files that have yet to be synced when clicking "Free up space" Mar 6, 2023
@killing
Copy link
Member

killing commented Apr 17, 2023

We'll look into this issue.

@pmdevita
Copy link
Author

Any update on this by chance?

@killing
Copy link
Member

killing commented Sep 12, 2024

This has been fixed in some version. You should not see this issue with the latest version.

@pmdevita
Copy link
Author

Great, thank you! I'll give it another test and close the issue if it works alright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants