Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Go modules #574

Closed
hajimehoshi opened this issue Apr 3, 2018 · 2 comments
Closed

Prepare for Go modules #574

hajimehoshi opened this issue Apr 3, 2018 · 2 comments
Milestone

Comments

@hajimehoshi
Copy link
Owner

hajimehoshi commented Apr 3, 2018

This is just random notes to myself:

  • go.mod is needed not only at ebiten package but also all the example main packages.
  • To test a new major version on non-master branch, it looks like at least tagging is required. => branch-lookup would solve this: x/vgo: look up branches (not just tags) in version fixer golang/go#24045
  • vgo run with specifying Go files doesn't recognize the main packages version-ed path. In other words, we can't have the below go.mod for vgo run?
module "github.com/hajimehoshi/ebiten/v2/examples/blocks"

=> (v)go run with package name would be available golang/go#22726

  • vgo build accepts both modules paths (version-ed and not version-ed) for main packages
  • Is it possible to prevent from mixing old and new versions?
@hajimehoshi hajimehoshi added this to the v2.0.0 milestone Apr 3, 2018
@hajimehoshi
Copy link
Owner Author

As Go 1.10.3 already has minimal support for semantic versioning import paths, I think I can release 2.0 sooner than I expected (e.g. next to 1.8)?

@hajimehoshi hajimehoshi changed the title Prepare for vgo Prepare for Go modules Jul 17, 2018
@hajimehoshi
Copy link
Owner Author

go.mod already exists and let's keep updating it.

@hajimehoshi hajimehoshi modified the milestones: v2.0.0, v1.8.0 Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant