Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with building mmh3 with python 3.11 devel package on amazon linux 2023 #90

Closed
matejsp opened this issue Sep 21, 2024 · 4 comments
Assignees
Labels

Comments

@matejsp
Copy link

matejsp commented Sep 21, 2024

When trying to build with pip3.11 wheel ./mmh3-5.0.0.tar.gz. We are using pypi source distro.

Processing ./mmh3-5.0.0.tar.gz
  File was already downloaded /source/python311-mmh3-5.0.0/dist/mmh3-5.0.0.tar.gz
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Preparing metadata (pyproject.toml): started
  Preparing metadata (pyproject.toml): finished with status 'done'
Building wheels for collected packages: mmh3
  Building wheel for mmh3 (pyproject.toml): started
  Building wheel for mmh3 (pyproject.toml): finished with status 'error'
  error: subprocess-exited-with-error
  
  × Building wheel for mmh3 (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [27 lines of output]
      /tmp/pip-build-env-41448qpn/overlay/lib/python3.11/site-packages/setuptools/config/pyprojecttoml.py:71: ExperimentalConfiguration: `[tool.setuptools.ext-modules]` in `pyproject.toml` is still *experimental* and likely to change in future releases.
        config = read_configuration(filepath, True, ignore_option_errors, dist)
      running bdist_wheel
      running build
      running build_py
      running egg_info
      writing src/mmh3.egg-info/PKG-INFO
      writing dependency_links to src/mmh3.egg-info/dependency_links.txt
      writing requirements to src/mmh3.egg-info/requires.txt
      writing top-level names to src/mmh3.egg-info/top_level.txt
      reading manifest file 'src/mmh3.egg-info/SOURCES.txt'
      adding license file 'LICENSE'
      writing manifest file 'src/mmh3.egg-info/SOURCES.txt'
      creating build/lib.linux-aarch64-cpython-311/mmh3
      copying src/mmh3/__init__.pyi -> build/lib.linux-aarch64-cpython-311/mmh3
      copying src/mmh3/mmh3module.c -> build/lib.linux-aarch64-cpython-311/mmh3
      copying src/mmh3/murmurhash3.c -> build/lib.linux-aarch64-cpython-311/mmh3
      copying src/mmh3/py.typed -> build/lib.linux-aarch64-cpython-311/mmh3
      running build_ext
      building 'mmh3' extension
      creating build/temp.linux-aarch64-cpython-311/src/mmh3
      gcc -Wsign-compare -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -O2 -ftree-vectorize -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -march=armv8.2-a+crypto -mtune=neoverse-n1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -D_GNU_SOURCE -fPIC -fwrapv -O2 -ftree-vectorize -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -march=armv8.2-a+crypto -mtune=neoverse-n1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -D_GNU_SOURCE -fPIC -fwrapv -O2 -ftree-vectorize -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -march=armv8.2-a+crypto -mtune=neoverse-n1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -D_GNU_SOURCE -fPIC -fwrapv -fPIC -I/source/python311/include -I/usr/include/python3.11 -c ./src/mmh3/mmh3module.c -o build/temp.linux-aarch64-cpython-311/./src/mmh3/mmh3module.o
      ./src/mmh3/mmh3module.c:14:10: fatal error: hashlib.h: No such file or directory
         14 | #include "hashlib.h"
            |          ^~~~~~~~~~~
      compilation terminated.
      error: command '/usr/bin/gcc' failed with exit code 1
      [end of output]
@matejsp
Copy link
Author

matejsp commented Sep 22, 2024

The sdist (mmh3-5.0.0.tar.gz) is missing hashlib.h file

image

@hajimes
Copy link
Owner

hajimes commented Sep 22, 2024

Thank you very much for reporting the issue! I’ve fixed the problem in #91 and released the patched version as 5.0.1. Can you check if this resolves the issue?

@hajimes hajimes added the bug label Sep 22, 2024
@hajimes hajimes self-assigned this Sep 22, 2024
@matejsp
Copy link
Author

matejsp commented Sep 24, 2024

Yes with 5.0.1 the issue is resolved and it builds now. Thank you very much!

@matejsp matejsp closed this as completed Sep 24, 2024
@hajimes
Copy link
Owner

hajimes commented Sep 24, 2024

You're welcome, and thanks for confirming the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants