-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown plugin: add markdown slides at runtime #586
Closed
croeck opened this issue
Sep 4, 2013
· 3 comments
· May be fixed by Itchibon777/reveal.js#3, HelloKittyHacker/reveal.js#3, 137717unity/reveal.js#3, Ngugisenior/reveal.js#3 or SarahU/reveal.js#3
Closed
Markdown plugin: add markdown slides at runtime #586
croeck opened this issue
Sep 4, 2013
· 3 comments
· May be fixed by Itchibon777/reveal.js#3, HelloKittyHacker/reveal.js#3, 137717unity/reveal.js#3, Ngugisenior/reveal.js#3 or SarahU/reveal.js#3
Labels
Comments
Sure, I'm all for adding an API to the plugin and using |
+1 for this idea. |
Just added this to the dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I would love to add slides to my presentation while it is already running. With most aspects of reveal.js this is working great. However, the markdown slides are parsed while reveal.js is being initialized and currently there is no possibility to re-run the markdown plugin.
First, I would request to provide a simple API call for the markdown plugin to initialize all markdown slides, similar to reveal.js itself.
The following code refers to the bottom of the
markdown.js
file in the markdown plugin and would implement this functionality:Second, this would require to change the existing methods because already parsed slides would be parsed again and therefore become corrupted.
My first thought was to remove the
data-markdown
attribute after a section has been parsed and add adata-markdown-parsed
attribute instead.Basically both changes are working as desired, but I am not quite sure about the side-effects this would have, especially on the notes part of reveal.js
I would love to hear your comments on this.
(And thanks for the already fantastic tool!)
The text was updated successfully, but these errors were encountered: