Search no longer works on Mastodon < 2.8.0

[jfmcbrayer]

The required version for mastodon.search() and mastodon.search_v2() were bumped to 2.8.0, probably because 2.8.0 added paging parameters. However, it should still be possible to search without paging on Mastodon < 2.8.0, as it was before.

This is causing https://github.com/jfmcbrayer/brutaldon/issues/63.

[halcy]

Oh bother, yeah, it should not be broken. I did change search to use search_v2 by default, but that should still work on older (though not TOO old) versions. Maybe it should select what function to use dynamically based on if v2 is available anyways.

I'll look into it.

[jfmcbrayer]

Looking at the documentation, it looks like search_v2 should be for 2.4.1 and later.

The additional parameters type, limit, offset, min_id, max_id, and account_id were added in 2.8.0, but are still not documented in the official API documentation, only in the pull request here: mastodon/mastodon#10091

Arguably, it would be better to support search_v2 for 2.4.1 and later, but push the additional parameters to a separate function that's only available for 2.8.0 and later.

[halcy]

I'd prefer not having ANOTHER separate version, so maybe the following would be good:

1. If < 2.4.1, search uses search_v1, otherwise v2

2. If < 2.8.0 and pagination parameters are passed, a meaningful error is thrown client-side that you can catch and that is documented. If they are not passed, they are not sent automatically. This is probably what should have happened to begin with.

Does that sound good to you from an application perspective?

[jfmcbrayer]

Yeah, that's totally reasonable.

[halcy]

Fixed in 8675b25

[halcy]

Unsure why the comments are out of order. Fixed in 8675b25

[jfmcbrayer]

Thanks for the fast fix; this probably merits a release in order to fix broken clients. (Selfishly, I want this to fix brutaldon).

[halcy]

yeah, will absolutely do a release, I just want to also get full 2.8.2 support in and re-run the unit tests. Will likely do all of that after I get home from work, I already got blurhash decoding working yesterday, so expect 1.4.1 in maybe 10 to 12 hours from now.

[halcy]

well, might unfortunately not quite make it today, but tomorrow, I'll definitely get this done.