.clang-tidy

# TODO: some of the blocklisted bugprone checks can/should be re-enabled
# one at a time (with careful code fixes made as necessary).

---
Checks: >
    -*,

    # For reasons that aren't clear, clang-tidy-16 will apparently
    # ignore disable-check requests if they were already enabled
    # by a glob, so we will individually enumerate all the ones we want (or don't want).
    # bugprone-*,
    bugprone-argument-comment,
    bugprone-assert-side-effect,
    -bugprone-assignment-in-if-condition,
    bugprone-bad-signal-to-kill-thread,
    bugprone-bool-pointer-implicit-conversion,
    -bugprone-branch-clone,
    bugprone-copy-constructor-init,
    bugprone-dangling-handle,
    bugprone-dynamic-static-initializers,
    -bugprone-easily-swappable-parameters,
    -bugprone-empty-catch,
    -bugprone-exception-escape,
    bugprone-fold-init-type,
    bugprone-forward-declaration-namespace,
    bugprone-forwarding-reference-overload,
    -bugprone-implicit-widening-of-multiplication-result,
    bugprone-inaccurate-erase,
    bugprone-incorrect-roundings,
    bugprone-infinite-loop,
    -bugprone-integer-division,
    bugprone-lambda-function-name,
    bugprone-macro-parentheses,
    bugprone-macro-repeated-side-effects,
    bugprone-misplaced-operator-in-strlen-in-alloc,
    bugprone-misplaced-pointer-arithmetic-in-alloc,
    bugprone-misplaced-widening-cast,
    bugprone-move-forwarding-reference,
    bugprone-multiple-new-in-one-expression,
    bugprone-multiple-statement-macro,
    -bugprone-narrowing-conversions,
    bugprone-non-zero-enum-to-bool-conversion,
    bugprone-no-escape,
    bugprone-not-null-terminated-result,
    bugprone-parent-virtual-call,
    bugprone-posix-return,
    bugprone-redundant-branch-condition,
    -bugprone-reserved-identifier,
    bugprone-shared-ptr-array-mismatch,
    bugprone-signal-handler,
    -bugprone-signed-char-misuse,
    bugprone-sizeof-container,
    bugprone-sizeof-expression,
    bugprone-spuriously-wake-up-functions,
    bugprone-standalone-empty,
    bugprone-string-constructor,
    bugprone-string-integer-assignment,
    bugprone-string-literal-with-embedded-nul,
    bugprone-stringview-nullptr,
    bugprone-suspicious-enum-usage,
    bugprone-suspicious-include,
    bugprone-suspicious-memory-comparison,
    bugprone-suspicious-memset-usage,
    bugprone-suspicious-missing-comma,
    bugprone-suspicious-realloc-usage,
    bugprone-suspicious-semicolon,
    bugprone-suspicious-string-compare,
    bugprone-swapped-arguments,
    bugprone-switch-missing-default-case,
    bugprone-terminating-continue,
    bugprone-throw-keyword-missing,
    bugprone-too-small-loop-variable,
    -bugprone-unchecked-optional-access, # Too many false-positives
    bugprone-undefined-memory-manipulation,
    bugprone-undelegated-constructor,
    bugprone-unhandled-exception-at-new,
    bugprone-unhandled-self-assignment,
    bugprone-unique-ptr-array-mismatch,
    bugprone-unsafe-functions,
    bugprone-unused-raii,
    bugprone-unused-return-value,
    bugprone-use-after-move,
    bugprone-virtual-near-miss,

    clang-diagnostic-shadow-field,

    cppcoreguidelines-avoid-capturing-lambda-coroutines,
    cppcoreguidelines-misleading-capture-default-by-value,
    -cppcoreguidelines-missing-std-forward,  # TODO: consider enabling
    cppcoreguidelines-rvalue-reference-param-not-moved,

    misc-confusable-identifiers,
    -misc-const-correctness,
    misc-definitions-in-headers,
    misc-header-include-cycle,
    -misc-include-cleaner,
    misc-misleading-bidirectional,
    misc-misleading-identifier,
    misc-misplaced-const,
    misc-new-delete-overloads,
    -misc-no-recursion,
    misc-non-copyable-objects,
    -misc-non-private-member-variables-in-classes,
    misc-redundant-expression,
    misc-static-assert,
    misc-throw-by-value-catch-by-reference,
    -misc-unconventional-assign-operator,
    misc-uniqueptr-reset-release,
    misc-unused-alias-decls,
    -misc-unused-parameters,
    misc-unused-using-decls,
    misc-use-anonymous-namespace,

    -modernize-avoid-bind,
    -modernize-avoid-c-arrays,
    -modernize-concat-nested-namespaces,
    modernize-deprecated-headers,
    -modernize-deprecated-ios-base-aliases,
    -modernize-loop-convert,
    -modernize-macro-to-enum,
    modernize-make-shared,
    modernize-make-unique,
    -modernize-pass-by-value,
    -modernize-raw-string-literal,
    modernize-redundant-void-arg,
    -modernize-replace-auto-ptr,
    -modernize-replace-disallow-copy-and-assign-macro,
    -modernize-replace-random-shuffle,
    -modernize-return-braced-init-list,
    -modernize-shrink-to-fit,
    -modernize-type-traits,
    -modernize-unary-static-assert,
    -modernize-use-auto,
    modernize-use-bool-literals,
    modernize-use-default-member-init,
    modernize-use-emplace,
    modernize-use-equals-default,
    modernize-use-equals-delete,
    -modernize-use-nodiscard,
    -modernize-use-noexcept,
    modernize-use-nullptr,
    modernize-use-override,
    -modernize-use-std-print,
    -modernize-use-trailing-return-type,
    -modernize-use-transparent-functors,
    -modernize-use-uncaught-exceptions,
    -modernize-use-using,

    performance-avoid-endl,
    performance-faster-string-find,
    performance-for-range-copy,
    performance-implicit-conversion-in-loop,
    performance-inefficient-algorithm,
    -performance-inefficient-string-concatenation,
    -performance-inefficient-vector-operation,
    performance-move-const-arg,
    performance-move-constructor-init,
    performance-no-automatic-move,
    -performance-no-int-to-ptr,
    performance-noexcept-destructor,
    performance-noexcept-move-constructor,
    performance-noexcept-swap,
    performance-trivially-destructible,
    performance-type-promotion-in-math-fn,
    performance-unnecessary-copy-initialization,
    performance-unnecessary-value-param,

    readability-avoid-const-params-in-decls,
    -readability-avoid-unconditional-preprocessor-if,
    readability-braces-around-statements,
    readability-const-return-type,
    -readability-container-contains,
    -readability-container-data-pointer,
    readability-container-size-empty,
    -readability-convert-member-functions-to-static,
    -readability-delete-null-pointer,
    -readability-duplicate-include,
    -readability-else-after-return,
    -readability-function-cognitive-complexity,
    -readability-function-size,
    -readability-identifier-length,
    -readability-identifier-naming,
    -readability-implicit-bool-conversion,
    -readability-inconsistent-declaration-parameter-name,
    -readability-isolate-declaration,
    -readability-magic-numbers,
    -readability-make-member-function-const,
    -readability-misleading-indentation,
    readability-misplaced-array-index,
    -readability-named-parameter,
    -readability-non-const-parameter,
    -readability-operators-representation,
    readability-qualified-auto,
    readability-redundant-access-specifiers,
    readability-redundant-control-flow,
    -readability-redundant-declaration,
    readability-redundant-function-ptr-dereference,
    -readability-redundant-member-init,
    readability-redundant-preprocessor,
    readability-redundant-smartptr-get,
    readability-redundant-string-cstr,
    -readability-redundant-string-init,
    -readability-simplify-boolean-expr,
    readability-simplify-subscript-expr,
    readability-static-accessed-through-instance,
    readability-static-definition-in-anonymous-namespace,
    -readability-string-compare,
    -readability-suspicious-call-argument,
    -readability-uniqueptr-delete-release,
    -readability-uppercase-literal-suffix,
    -readability-use-anyofallof,

WarningsAsErrors: '*'
HeaderFilterRegex: '.*'
FormatStyle: 'file'
CheckOptions:
    - key:   modernize-use-default-member-init.UseAssignment
      value: 1
...