Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Ninja for packaging on Windows #5264

Open
steven-johnson opened this issue Sep 11, 2020 · 3 comments
Open

Use Ninja for packaging on Windows #5264

steven-johnson opened this issue Sep 11, 2020 · 3 comments
Assignees
@alexreinking
Labels
build Issues related to building Halide and with CI
Milestone
v13.0.0

Comments

@steven-johnson
Copy link
Contributor

Due to an apparent bug in CMake 3.18, we can't use Ninja to drive Multi-Config packaging, and must use MSBuild instead. This is gross and inconvenient. This is a tracking bug to verify we switch to Ninja there if/when possible.
@alexreinking alexreinking self-assigned this Sep 11, 2020
@alexreinking alexreinking added the build Issues related to building Halide and with CI label Sep 11, 2020
@alexreinking
Copy link
Member

I will investigate & minimize after my CppCon talk.

@alexreinking alexreinking added this to the v12.0.0 milestone Oct 19, 2020
@alexreinking alexreinking modified the milestones: v12.0.0, v13.0.0 Apr 16, 2021
@steven-johnson
Copy link
Contributor Author

Presumably we can fix this once #6910 lands (the relevant comment at master.cfg:912 indicates the bug is in CMake 3.18)?

@alexreinking
Copy link
Member

I hope so! It looks like some of the issues I had opened related to this have been closed since I last checked:

https://gitlab.kitware.com/cmake/cmake/-/issues/22023 (still open, but maybe not a blocker)
https://gitlab.kitware.com/cmake/cmake/-/issues/21973 (fixed in 3.20, was a blocker)
https://gitlab.kitware.com/cmake/cmake/-/issues/21982 (still open, but maybe not a blocker)
https://gitlab.kitware.com/cmake/cmake/-/issues/21983 (fixed in 3.22, but comments are concerning, was a blocker)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexreinking alexreinking

Labels
build Issues related to building Halide and with CI
Projects
None yet
Milestone
v13.0.0
Development

No branches or pull requests
2 participants
@alexreinking @steven-johnson