Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize file system walking #2

Closed
haltcase opened this issue Jun 1, 2018 · 2 comments
Closed

Optimize file system walking #2

haltcase opened this issue Jun 1, 2018 · 2 comments
Labels
type: performance Opportunity for performance improvements.

Comments

@haltcase
Copy link
Owner

haltcase commented Jun 1, 2018

Right now we use walkDirRec which traverses recursively into directories automatically. This means glob potentially walks over a lot of files that the given pattern might completely ignore. Instead it should probably use walkDir so that we can decide whether to recurse into the directories as we come across them.

@haltcase haltcase added the type: performance Opportunity for performance improvements. label Jun 1, 2018
@data-man
Copy link

data-man commented Jun 1, 2018

Related RFC nim-lang/Nim#7077 😄

@haltcase haltcase added the status: in progress Work has started to close the issue. label Jun 1, 2018
@haltcase
Copy link
Owner Author

haltcase commented Jun 1, 2018

@data-man thanks although I ended up basically modifying walkDirRec and adding logic as needed. Any chance you could check out the PR? I want to run a comparison test on a fairly large directory structure before merging, but it should be good otherwise.

(this reminds me I still need to set up CI)

@haltcase haltcase added status: pending release Issue is resolved but waiting to be released. and removed status: in progress Work has started to close the issue. status: pending release Issue is resolved but waiting to be released. labels Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: performance Opportunity for performance improvements.
Projects
None yet
Development

No branches or pull requests

2 participants