Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileSystemCaseSensitive should now be used now that https://github.com/nim-lang/Nim/pull/8411 was merged #26

Closed
timotheecour opened this issue Jul 24, 2018 · 4 comments
Closed

FileSystemCaseSensitive should now be used now that https://github.com/nim-lang/Nim/pull/8411 was merged #26

timotheecour opened this issue Jul 24, 2018 · 4 comments
Labels
external Issues with dependencies or otherwise unsolvable within the project itself. type: refactor Improvements with no change in functionality.

Comments

@timotheecour
Copy link
Collaborator

my PR nim-lang/Nim#8411 was merged, so FileSystemCaseSensitive should now be used instead of duplicating logic
@haltcase haltcase added external Issues with dependencies or otherwise unsolvable within the project itself. type: chore General maintenance or upkeep. labels Jul 24, 2018
@haltcase
Copy link
Owner

Already being used here but could be used here too.

@haltcase
Copy link
Owner

Fixed in glob but be aware part of the fix needs to be in a Nim release too.

@timotheecour
Copy link
Collaborator Author

be aware part of the fix needs to be in a Nim release too.

not sure what you mean; you mean the user won't benefit of this fix unless they use recent enough version of nim devel? if so, ya, that kinda stuff will be common...

@haltcase
Copy link
Owner

Yes but eventually it will make it to stable. FYI I plan to be pretty aggressive with requiring those as Nim closes in on 1.0.

@haltcase haltcase added type: refactor Improvements with no change in functionality. and removed type: chore General maintenance or upkeep. labels Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external Issues with dependencies or otherwise unsolvable within the project itself. type: refactor Improvements with no change in functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timotheecour @haltcase