-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Bump deno to v1.2 and std to v0.61 #67
Comments
Hi @njpearman ! Good thing you noticed this! You can submit the PR when you are ready, and I will review it as soon as possible to get it available with a new tag! From what I can see, Denomander and Postgres have had the update merged, but MySQL and SQLite are not yet up to date. If you submit the PR with an update to the CI (just change the Deno version to 1.2), we can see if the pipeline succeeds or not 👍 |
Okay. It's annoying that neither |
@njpearman Denomander now has version 0.6.3 👍 |
Do you want me to assign this issue to you? |
Also, as an alternative to tagged releases, it's possible to use commit hashes instead of tags, if you want a quick and dirty way to lock down the version. |
@halvardssm |
Perfect! I actually forgot about the hash hack, but good thing @Yamboy1 thought of it! I looked over your PR, and I think we can deem it good to merge as long as the tests pass 👍 |
Actually, with the new deno_registry2, the hash idea doesn't work anymore, you can only use tagged releases now, so i think you'll need to use github raw or something else to do that, not entirely sure tho |
ah, that's what you are doing, 👍 |
System (please complete the following information):
Describe the bug
Deno v1.2 has introduced a breaking change around the
URL
constructor, strictly requiring a type ofstring
. This means any modules referencingstd
need to be bumped to v0.61 to work with Deno v1.2. See denoland/deno#5365 (comment) for more details.I've started on an upgrade to
nessie
here: https://github.com/njpearman/deno-nessie/tree/deno-1.2 but there are dependencies that need version bumps first, so I can't open a PR until they have published upgrades. I'm creating this issue to keep a track of things. Hope that's useful :)denomander
upgrade, PR here: Bumps Deno to v1.2 and std to v0.61 siokas/denomander#23deno-postgres
upgrade, PR here: chore: bump Deno to v1.2.0 denodrivers/postgres#152Probably upgrades needed for MySQL and SQLite too?
The text was updated successfully, but these errors were encountered: