Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bump deno to v1.2 and std to v0.61 #67

Closed
2 tasks done
njpearman opened this issue Jul 14, 2020 · 9 comments · Fixed by #71
Closed
2 tasks done

[BUG] Bump deno to v1.2 and std to v0.61 #67

njpearman opened this issue Jul 14, 2020 · 9 comments · Fixed by #71
Labels
bug Something isn't working

Comments

@njpearman
Copy link
Contributor

njpearman commented Jul 14, 2020

System (please complete the following information):

  • OS: macos
  • Deno v1.2.0
  • Nessie 0.10.0

Describe the bug

Deno v1.2 has introduced a breaking change around the URL constructor, strictly requiring a type of string. This means any modules referencing std need to be bumped to v0.61 to work with Deno v1.2. See denoland/deno#5365 (comment) for more details.

I've started on an upgrade to nessie here: https://github.com/njpearman/deno-nessie/tree/deno-1.2 but there are dependencies that need version bumps first, so I can't open a PR until they have published upgrades. I'm creating this issue to keep a track of things. Hope that's useful :)

Probably upgrades needed for MySQL and SQLite too?

@njpearman njpearman added the bug Something isn't working label Jul 14, 2020
@halvardssm
Copy link
Owner

Hi @njpearman ! Good thing you noticed this! You can submit the PR when you are ready, and I will review it as soon as possible to get it available with a new tag! From what I can see, Denomander and Postgres have had the update merged, but MySQL and SQLite are not yet up to date. If you submit the PR with an update to the CI (just change the Deno version to 1.2), we can see if the pipeline succeeds or not 👍

@njpearman
Copy link
Contributor Author

Okay. It's annoying that neither denomander nor deno-postgres have tagged a version for the fixes yet so I guess it should wait until they do. I'll keep an eye out for when they do.

@halvardssm
Copy link
Owner

@njpearman Denomander now has version 0.6.3 👍

@halvardssm
Copy link
Owner

Do you want me to assign this issue to you?

@Yamboy1
Copy link

Yamboy1 commented Aug 1, 2020

Also, as an alternative to tagged releases, it's possible to use commit hashes instead of tags, if you want a quick and dirty way to lock down the version.

@njpearman
Copy link
Contributor Author

@halvardssm deno-postgres still doesn't have a release with the v1.2 upgrade but I'll use the commit hash hack as suggested by @Yamboy1 . sqlite is still not on Deno v1.2, which seems fine to me as I can't see any stdlib refs but I might be wrong.

@halvardssm halvardssm linked a pull request Aug 3, 2020 that will close this issue
7 tasks
@halvardssm
Copy link
Owner

Perfect! I actually forgot about the hash hack, but good thing @Yamboy1 thought of it! I looked over your PR, and I think we can deem it good to merge as long as the tests pass 👍

@Yamboy1
Copy link

Yamboy1 commented Aug 6, 2020

Actually, with the new deno_registry2, the hash idea doesn't work anymore, you can only use tagged releases now, so i think you'll need to use github raw or something else to do that, not entirely sure tho

@Yamboy1
Copy link

Yamboy1 commented Aug 6, 2020

ah, that's what you are doing, 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants