Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable exitcode is not been cleaned before every domain validation #42

Open
rafael747 opened this issue May 10, 2018 · 0 comments
Open

Comments

@rafael747
Copy link

let exitcode=tries=0
until [ $tries -ge $MAXRETRIES ]
do
tries=$[$tries+1]
certbot-auto certonly --dry-run "${args[@]}" -d "$i" | grep -q 'The dry run was successful.' && break
exitcode=$?

This way, after a initial failure of domain validation, the exitcode variable are only redefined when the validation fails again. If the validation succeeds, the exitcode remains with the value of previous iteration because the "break" statement.

This cause the domain to not be included in the certificate generation.

To work correctly, the exitcode variable needs to be cleaned before every domain validation trial

@rafael747 rafael747 changed the title variable exitcode is only defined before the until loop variable exitcode is not been cleaned before every domain validation May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant