-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide back compatible StringContains constructors #259
Comments
For background, here's an example of a problem cause by the change: spring-projects/spring-boot#15555 (comment) |
@tumbarumba, I don't see a milestone assigned to this issue. Do you have an idea when this might be released? |
@tumbarumba Looks good to me. Thanks for the fast turnaround! |
@tumbarumba, a bug fix release would be great! Thanks |
Just noticed I didn't closed this last year. It was fixed in release 2.2. |
Commit 639b99e changed the public constructors of
StringContains
StringEndsWith
andStringStartsWith
so that they now required anignoreCase
flag. This unfortunately can break anyone that happens to be calling those constructors directly rather than using the static factory methods.Could additional constructors please be provided alongside the new ones so that Hamcrest 2.x remains compatible with earlier versions?
The text was updated successfully, but these errors were encountered: