Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include cmdb plugin #39

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

ml019
Copy link
Contributor

@ml019 ml019 commented Apr 29, 2021

Intent of Change

  • New feature (non-breaking change which adds functionality)

Description

Include the cmdb plugin in the image.

Motivation and Context

By including the cmdb plugin, it makes continued testing of its use easier given the auto-detection logic in the bash executor.

Note that because the cmdb plugin is not currently included in the GENERATION_PLUGIN_DIRS environment variable, dynamic cmdb processing won't be active by default, but simply by adding it as an extra path value to this variable, dynamic cmdb loading will be activated.

How Has This Been Tested?

It hasn't - simple enough that any issues will be fixed following any issues in container build pipeline.

Related Changes

Prerequisite PRs:

  • None

Dependent PRs:

  • None

Consumer Actions:

  • None

Include the cmdb plugin in the image.

By including the cmdb plugin, it makes continued testing of its use
easier given the auto-detection logic in the bash executor.

Note that because the cmdb plugin is not currently included in the
`GENERATION_PLUGIN_DIRS` environment variable, dynamic cmdb processing
won't be active by default, but simply by adding it as an extra path
value to this variable, dynamic cmdb loading will be activated.
@ml019 ml019 requested a review from a team April 29, 2021 08:06
@roleyfoley roleyfoley merged commit 14dea8e into hamlet-io:master Apr 29, 2021
@ml019 ml019 deleted the refactor-include-cmdb-plugin branch April 29, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants