Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component name based extension handling #2010

Open
roleyfoley opened this issue Jun 10, 2022 · 1 comment
Open

Remove component name based extension handling #2010

roleyfoley opened this issue Jun 10, 2022 · 1 comment

Comments

@roleyfoley
Copy link
Contributor

Expected Behaviour

All Extensions/Fragments are explicitly defined in the solution configuration of a component

Current Behaviour

When components are invoking extensions they currently use two methods to determine the extensions that should be invoked

  • Using the Component Name/Instance/Version to generate a matching extension name
  • Explicit definition by a user using the Extensions attribute on components which support extension based management

The first is not documented and is more a magic approach, If you don't know it exists it can cause issues ( such as naming two related components that have different component types and then a fragment specifcally targetting a given component type is used on another type )

Possible Solution

Remove support for the name based approach and require that all extensions are explicitly defined through the Extensions component attribute

Context

This simplifies the configuration and understanding of how extensions and components work. With the introduction of the various ways we can now manage configuration applied to components the use for a "magic"/implied implementation isn't really required.

@ml019
Copy link
Contributor

ml019 commented Jun 10, 2022

I support this change. It also means the current magic behaviour of a value starting with _ also disappears - it is just an exact match on whatever name you provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants