Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-built PNGs #143

Open
wyattoday opened this issue Apr 20, 2023 · 2 comments
Open

Remove pre-built PNGs #143

wyattoday opened this issue Apr 20, 2023 · 2 comments

Comments

@wyattoday
Copy link
Collaborator

wyattoday commented Apr 20, 2023

Hey @hampusborgos,

A major block in me contributing more lately has been the presence of pre-built pngs in the repository. Every flag with errors requires a ton of work to generate the PNGs for them. I just don't have the time (or patience) to do that extra work.

Would you be OK if I removed the png* folders? Users could still regenerate the sizes they needed, and it would significantly increase the speed and frequency at which I contribute fixes & updates to this repository.

I will start contributing more (starting today), but I definitely will not be touching the PNGs anymore. And rather than have the PNGs and SVGs get more and more out-of-sync, it makes more sense to just nuke the PNGs altogether.

I didn't want to to make this change unilaterally.

@hampusborgos
Copy link
Owner

Hello, is the script not sufficient to generate the PNGs? Potentially it could run as a GitHub action, so it is automatic.

@wyattoday
Copy link
Collaborator Author

The script has never worked for me. I’m on Windows and use the latest NodeJS.

I briefly considered fixing it to work on Windows, but we have no need for pngs in our org, and it wasn’t a good use of my time.

I’d be on board with a GitHub action that autocommits the png versions of any changes to SVGs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants