Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom user agent #103

Closed
samwilson opened this issue Jul 3, 2021 · 3 comments
Closed

Allow custom user agent #103

samwilson opened this issue Jul 3, 2021 · 3 comments
Labels
Feature Requests

Comments

@samwilson
Copy link
Collaborator

It would be good to be able to set a custom user agent, so that clients using this library can abide by the User-Agent policy.

I suggest adding a new method: Wikimate::setUserAgent( string $userAgent ): void
@samwilson
Copy link
Collaborator Author

This is to help with https://phabricator.wikimedia.org/T286099

@Xymph
Copy link
Collaborator

Xymph commented Jul 3, 2021

We're just in the process of wrapping up v0.13.0, so I'll schedule this for the next release (it's a small easy addition).
Nice to see this little library in use at big Mediawiki. :)

@Xymph Xymph mentioned this issue Jul 4, 2021
Open
@Xymph
Copy link
Collaborator

Xymph commented Jul 6, 2021

This is now resolved in master, and will be in the v0.14.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samwilson @Xymph