Start cleaning up sweep algorithm #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sweep algorithm has been cleaned up many times already, but it keeps being a thorn in my side. Right now, because it makes various dodgy assumptions that prevent a big simplification from being made (#1020).
This is the start of an attempt to divide the edge sweeping code into smaller, more easily understood pieces, while also making it more correct and less dodgy at the same time. I have code in a local branch that continues this work, but since I'm having problems getting this ready, I figured I'd start with these humble beginnings.