Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new form of vertices,
SurfaceVertex
, which is defined in 2D surface coordinates. Citing from one of the commit messages:The trade-off is complexity, but I think the added reliability (which isn't realized, since
SurfaceVertex
isn't included in validation yet) is worth it. Another way to view this change is that it doesn't add complexity, but just makes the inherent complexity explicit.It would be a bit of a pay-off to update the curve approximation code to not re-compute the surface coordinates. But that would require some more changes there, and I felt that this pull request is already big enough.