Clean up Surface
#1080
Merged
Clean up Surface
#1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simplification that I should have done a long time ago. I figured, it is only a matter of time, before we add more types of surfaces, so I thought it made sense to keep `Surface` an enum. That might well be true, but in the meantime, this decision makes lots of code more complicated. Once we want to add more types of curves, we can easily turn `Surface` into an enum again.
`curve` and `path` hardly tell a clear story. I think it's better to name the fields after the coordinate system axes they define.
Continues the introduction of new nomenclature that began in the previous commit.
This follows the example set by other objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
Surface, clean up the nomenclature it uses, and bring its API in line with that of other objects.