Shuffle around some code in fj::Sketch
#1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on #100 on the side, hoping I could implement it relatively quickly, but I ran out of juice. I'd have to modify
ffi_safe::Vecin a non-trivial way now, and I'd rather not attempt that. I have enough non-trivial projects going on and don't want to take on another one.I've decided to merge the commits I've made so far. They don't change a lot, but they bring
fj::Sketcha few steps closer to being able to support a mix of lines and arcs. Maybe this will be helpful, once someone picks this back up.