Introduce new partial object API #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes `Default` implementations for all partial objects.
This makes the implementation of the new partial object API more uniform, and also less error-prone: If the constructors are made to do something, this isn't accidentally bypassed in `Default`.
This was referenced Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a completely new partial object API, meant to replace the old one. The goal is to fully address #1249.
The core innovation of this API, compared to the old one, is that there is a notion of object identity which parallels the same notion that exists with full objects. Thanks to this, a partial object graph can directly map to the full object graph that is constructed from it. This removes the need for complicated build code, which the old API uses to make sure that the full object graph being built is connected correctly. With this new API, objects can be connected correctly from the start, and this is carried through the complete construction process.
The new API is not complete yet, but the design is there and has been partially proven. So far, it is clear that the design works in principle, and that the new approach is capable of delivering at least some simplifications. I will submit the branch where I've done this work after this pull request is merged.
What is not proven yet, is that this new design is indeed capable of taking care of #1249 completely. So far, I haven't seen any evidence to the contrary though, and I remain optimistic.
This pull request is only the start. It adds the new infrastructure, but the work to replace the old partial object API is not included.