Lift limitation when inferring surface as plane #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it only supported inferring a plane from exactly three vertices. Now it supports faces with more vertices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
FaceBuilder::update_surface_as_planeexpected the surface exterior to contain exactly 3 vertices. Now it can handle more vertices. It uses the first three to infer the plane and projects the rest of them into the inferred surface. This can lead to validation failures later on, if the vertices don't all fit into a plane.I'm currently working on rewriting parts of the sweep code to advance #1525, and this is a building block required to do that.