Start moving reference to Surface from Cycle to Face
#1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous pull requests (#1596, #1597, #1598), I've made good progress towards addressing #1588. The last missing step is to move the references to
SurfacefromCycleintoFace. Then every existingSurfaceshould only be referenced once.This pull requests takes us part of the way there. It adds the
Surfacereference toFace/PartialFaceand makes some preparations to remove it fromCycle/PartialCycle. There's more left to do before the latter can be done, but I didn't manage to finish this today.I'm not aware of any blockers or serious problems. Just more work to be done, which I intend to do next week.