Make validation unit tests more explicit #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation check it was testing had already been removed. That the test didn't fail was in fact accidental.
This prevents a warning popping up due to the next change I'm working on.
This makes them easier to pattern-match on, which is important for some improvements to validation unit tests I'm working on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen it a few times now that validation unit tests that were supposed to fail didn't. This happened because such a test can easily trigger a different validation failure than it intended accidentally.
This pull requests makes all of the validation tests more explicit, adding a check for a specific error variant to each.