Expand Shell validation tests
#1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also test the validation check with valid geometry. This is very verbose, as we're lacking the right APIs to build `Shell`s. I'm working on changing that now.
This is a bit overly complicated, as not all the code changed here is actually improved by the `SurfaceBuilder`. However, keeping those different cases consistent makes the next refactoring steps easier.
The old names were inherited from the test were this code was originally written, and they no longer fit this more generic context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the
Shellvalidation tests by also testing the "valid" scenario, not just the "invalid" one. Expand the builder API to support that.This is a step towards #1713, but it doesn't quite get us where we need to. The new builder APIs are too specialized to be of any real use outside of what they're currently used for. They definitely need some more work.
On the plus side, all previous attempts to write builder APIs like this either turned out overly complicated, or failed outright. So the recent cleanup work really did help. This also gave me some new ideas on how to evolve the builder API further, and I'll try those out next.