Add "update" operations; use them to clean up Shell validation tests
#1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old names didn't make a lot of sense. Since we don't know anything about the points that the caller passes in, it only makes sense to name the faces after the order of the points, nothing that implies a position or orientation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the operations API, adding "update" operations. Use those new operations to clean up the
Shellvalidation unit tests.This gets us most of the way towards addressing #1713. The only thing I'd like to still do, is to write unit tests for the
Solidvalidation checks, expanding the operations API as necessary.