Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add star model #50

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Add star model #50

merged 1 commit into from
Jan 26, 2022

Conversation

hannobraun
Copy link
Owner

I wanted to add an example model with a star shape, both to test/demonstrate support for concave sketches and because I think the code that generates the star shape serves as a nice demonstration for the kind of thing that Code-CAD is useful for.

star

Results are decidedly mixed 😄

I haven't had a chance to look into it yet in any detail, although I'm pretty sure this displays two distinct problems:

  • Not all triangles are generated counter-clockwise.
  • Some triangles are discarded erroneously.

I'll look into it when I get a chance and will open/fix issues as required.

@hannobraun
Copy link
Owner Author

I've opened #59 and #60. Already fixed #59 in #61. Here's what the model looks like now:

Screenshot from 2022-01-20 20-08-33

Slightly better. Still working on #60.

@hannobraun
Copy link
Owner Author

Looks correct now, after #81.

Screenshot from 2022-01-25 18-05-02

This is not merge-ready though. I still want to put a star-shaped hole into it.

@hannobraun
Copy link
Owner Author

And done!

Screenshot from 2022-01-26 14-49-14

@hannobraun hannobraun marked this pull request as ready for review January 26, 2022 13:54
@hannobraun hannobraun merged commit 8717a9d into main Jan 26, 2022
@hannobraun hannobraun deleted the star branch January 26, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant