Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point arithmetic #547

Merged
merged 2 commits into from
May 7, 2022
Merged

Point arithmetic #547

merged 2 commits into from
May 7, 2022

Conversation

connor-lennox
Copy link
Contributor

Addresses #546 .

In addition to adding the new subtraction implementation, I've also gone and applied it to the relevant part of the vertices.rs code in a separate commit.

@connor-lennox connor-lennox requested a review from hannobraun as a code owner May 6, 2022 20:06
hannobraun
hannobraun approved these changes May 7, 2022
View reviewed changes
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @connor-lennox, looks great!

@hannobraun hannobraun merged commit 18f0b97 into hannobraun:main May 7, 2022
@hannobraun hannobraun mentioned this pull request May 7, 2022
Closed
@connor-lennox connor-lennox deleted the point-arithmetic branch May 9, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannobraun hannobraun hannobraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connor-lennox @hannobraun