Create and use Angle type
#619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
previously approved these changes
May 23, 2022
There was a problem hiding this comment.
Thank you, @gabsi26, this looks awesome!
I've left two minor suggestions. I can probably accept those myself after submitting this review.
Most likely many places have been missed since
hannobraun
force-pushed
the
implement_angle_type
branch
from
8aa467e
to
010a265
Compare
|
Added a commit to apply my suggestions. Also rebased on Thanks again, @gabsi26! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates and uses a new
Angletype in thefjmodule as suggested by #263