Fix bounding volume issue for swept shapes #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses hannobraun#566 This solution is probably less than ideal, since the bounding volume gets split up into its vertices, which then get individually translated. Signed-off-by: gabsi26 <gabriel.seebach@gmx.at>
hannobraun
reviewed
May 24, 2022
There was a problem hiding this comment.
Thank you, @gabsi26, looks and works excellently!
I left one suggestion, which I can probably apply myself, after I submit this pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #566
This solution is probably less than ideal,
since the bounding volume gets split up into its vertices,
which then get individually translated.
Signed-off-by: gabsi26 gabriel.seebach@gmx.at
edit (by @hannobraun):
Close #566 (to make sure the issue is closed automatically when this is merged)